Review from previous (merged) patch set made comment on a couple of style issues. In the same review a bug was reported. We start off fixing the bug then move on to fix the style issues. None of these issues are reported by checkpatch, Sparse, or Smatch. Some instances were introduced by Tobin Harding in the afore mentioned patch set. An attempt at fixing the whole driver was made, however, an audit of every 'if' statement was not conducted.
Patch 01 fixes incorrect usage of return value of memcmp(). Patch 02 adds explicit checks to calls to memcmp() across the whole driver. Patch 03 adds previously removed explicit checks to 'size' variables. Patch 04 adds previously removed braces to multi-line single statement code blocks. Code has not been tested. Patch set applies and builds on x86_64 and PowerPC. Tobin C. Harding (4): staging: ks7010: fix memcmp() bug staging: ks7010: add explicit check to memcmp() calls staging: ks7010: add explicit check to 'size' variables staging: ks7010: add braces to multi-line indent drivers/staging/ks7010/ks7010_sdio.c | 8 ++++---- drivers/staging/ks7010/ks_hostif.c | 35 ++++++++++++++++++----------------- drivers/staging/ks7010/ks_wlan_net.c | 19 +++++++++---------- 3 files changed, 31 insertions(+), 31 deletions(-) -- 2.7.4 _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
