On Mon, Jul 17, 2017 at 04:17:22PM -0400, David Kershner wrote: > From: Sameer Wadgaonkar <sameer.wadgaon...@unisys.com> > > Cleaned up the in-line comments in the structure and added a > kernel-doc like comment for the structure. > > Signed-off-by: Sameer Wadgaonkar <sameer.wadgaon...@unisys.com> > Signed-off-by: David Kershner <david.kersh...@unisys.com> > Reviewed-by: David Binder <david.bin...@unisys.com> > --- > drivers/staging/unisys/visornic/visornic_main.c | 86 ++++++++++++------ > 1 file changed, 61 insertions(+), 25 deletions(-) > > diff --git a/drivers/staging/unisys/visornic/visornic_main.c > b/drivers/staging/unisys/visornic/visornic_main.c > index 0b39676..90d9d03 100644 > --- a/drivers/staging/unisys/visornic/visornic_main.c > +++ b/drivers/staging/unisys/visornic/visornic_main.c > @@ -68,10 +68,68 @@ struct chanstat { > unsigned long extra_rcvbufs_sent; > }; > > +/* struct visornic_devdata
If you are going to do kernel-doc, do it correctly please. Don't make it half-way, that helps no one as a follow-on patch to do it correctly is now required. Please do it correct the first time. thanks, greg k-h _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel