Am 31.07.2017 um 09:14 schrieb janani-sankarababu: > This patch is to replace the use of BUG_ON macro with WARN_ON > inorder to prevent the crashing of the kernel.
Unfortunately it isn't always that simple. checkpatch isn't smart. It's preferred to handle error cases instead of flooding the kernel log. > > Signed-off-by: Janani Sankara Babu <janani...@gmail.com> > --- > drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c > b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c > index f484bb0..30bc246 100644 > --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c > +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c > @@ -91,7 +91,7 @@ static int snd_bcm2835_ctl_get(struct snd_kcontrol > *kcontrol, > if (mutex_lock_interruptible(&chip->audio_mutex)) > return -EINTR; > > - BUG_ON(!chip && !(chip->avail_substreams & AVAIL_SUBSTREAMS_MASK)); > + WARN_ON(!chip && !(chip->avail_substreams & AVAIL_SUBSTREAMS_MASK)); The complete logic seems strange to me and the statement before didn't even check for chip. Regards Stefan > > if (kcontrol->private_value == PCM_PLAYBACK_VOLUME) > ucontrol->value.integer.value[0] = chip2alsa(chip->volume); _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
