Reviewed-by: Marcus Wolf <li...@wolf-entwicklungen.de> Maybe lnaGain should move to lna_gain instead of lnagain (also applies to the headers...)
Marcus Am Di, 1.08.2017, 21:31 schrieb Rishabh Hardas: > Signed-off-by: Rishabh Hardas <rishabhhar...@gmail.com> > --- > drivers/staging/pi433/rf69.c | 26 +++++++++++++------------- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c > index f83523e..7fa63e1 100644 > --- a/drivers/staging/pi433/rf69.c > +++ b/drivers/staging/pi433/rf69.c > @@ -109,2 +109,2 @@ enum modulation rf69_get_modulation(struct spi_device > *spi) > } > } > > -int rf69_set_modulation_shaping(struct spi_device *spi, enum modShaping > modShaping) > +int rf69_set_modulation_shaping(struct spi_device *spi, enum mod_shaping > modShaping) > { > #ifdef DEBUG > dev_dbg(&spi->dev, "set: mod shaping"); > @@ -264,2 +264,2 @@ int rf69_set_frequency(struct spi_device *spi, u32 > frequency) > return 0; > } > > -int rf69_set_amplifier_0(struct spi_device *spi, enum optionOnOff > optionOnOff) > +int rf69_set_amplifier_0(struct spi_device *spi, enum option_on_off > optionOnOff) > { > #ifdef DEBUG > dev_dbg(&spi->dev, "set: amp #0"); > @@ -277,2 +277,2 @@ int rf69_set_amplifier_0(struct spi_device *spi, enum > optionOnOff optionOnOff) > } > } > > -int rf69_set_amplifier_1(struct spi_device *spi, enum optionOnOff > optionOnOff) > +int rf69_set_amplifier_1(struct spi_device *spi, enum option_on_off > optionOnOff) > { > #ifdef DEBUG > dev_dbg(&spi->dev, "set: amp #1"); > @@ -290,2 +290,2 @@ int rf69_set_amplifier_1(struct spi_device *spi, enum > optionOnOff optionOnOff) > } > } > > -int rf69_set_amplifier_2(struct spi_device *spi, enum optionOnOff > optionOnOff) > +int rf69_set_amplifier_2(struct spi_device *spi, enum option_on_off > optionOnOff) > { > #ifdef DEBUG > dev_dbg(&spi->dev, "set: amp #2"); > @@ -319,2 +319,2 @@ int rf69_set_output_power_level(struct spi_device *spi, > u8 powerLevel) > return WRITE_REG(REG_PALEVEL, (READ_REG(REG_PALEVEL) & > ~MASK_PALEVEL_OUTPUT_POWER) | powerLevel); > } > > -int rf69_set_pa_ramp(struct spi_device *spi, enum paRamp paRamp) > +int rf69_set_pa_ramp(struct spi_device *spi, enum pa_ramp paRamp) > { > #ifdef DEBUG > dev_dbg(&spi->dev, "set: pa ramp"); > @@ -346,2 +346,2 @@ int rf69_set_pa_ramp(struct spi_device *spi, enum paRamp > paRamp) > } > } > > -int rf69_set_antenna_impedance(struct spi_device *spi, enum antennaImpedance > antennaImpedance) > +int rf69_set_antenna_impedance(struct spi_device *spi, enum > antenna_impedance antennaImpedance) > { > #ifdef DEBUG > dev_dbg(&spi->dev, "set: antenna impedance"); > @@ -359,2 +359,2 @@ int rf69_set_antenna_impedance(struct spi_device *spi, > enum antennaImpedance ant > } > } > > -int rf69_set_lna_gain(struct spi_device *spi, enum lnaGain lnaGain) > +int rf69_set_lna_gain(struct spi_device *spi, enum lnagain lnaGain) > { > #ifdef DEBUG > dev_dbg(&spi->dev, "set: lna gain"); > @@ -377,2 +377,2 @@ int rf69_set_lna_gain(struct spi_device *spi, enum > lnaGain lnaGain) > } > } > > -enum lnaGain rf69_get_lna_gain(struct spi_device *spi) > +enum lnagain rf69_get_lna_gain(struct spi_device *spi) > { > u8 currentValue; > > @@ -516,2 +516,2 @@ int rf69_set_ook_threshold_step(struct spi_device *spi, > enum thresholdStep thres > } > } > > -int rf69_set_ook_threshold_dec(struct spi_device *spi, enum > thresholdDecrement thresholdDecrement) > +int rf69_set_ook_threshold_dec(struct spi_device *spi, enum > threshold_decrement thresholdDecrement) > { > #ifdef DEBUG > dev_dbg(&spi->dev, "set: threshold decrement"); > @@ -666,2 +666,2 @@ int rf69_set_preamble_length(struct spi_device *spi, u16 > preambleLength) > return retval; > } > > -int rf69_set_sync_enable(struct spi_device *spi, enum optionOnOff > optionOnOff) > +int rf69_set_sync_enable(struct spi_device *spi, enum option_on_off > optionOnOff) > { > #ifdef DEBUG > dev_dbg(&spi->dev, "set: sync enable"); > @@ -753,2 +753,2 @@ int rf69_set_packet_format(struct spi_device * spi, enum > packetFormat packetForm > } > } > > -int rf69_set_crc_enable(struct spi_device *spi, enum optionOnOff optionOnOff) > +int rf69_set_crc_enable(struct spi_device *spi, enum option_on_off > optionOnOff) > { > #ifdef DEBUG > dev_dbg(&spi->dev, "set: crc enable"); > @@ -766,2 +766,2 @@ int rf69_set_crc_enable(struct spi_device *spi, enum > optionOnOff optionOnOff) > } > } > > -int rf69_set_adressFiltering(struct spi_device *spi, enum addressFiltering > addressFiltering) > +int rf69_set_adressFiltering(struct spi_device *spi, enum address_filtering > addressFiltering) > { > #ifdef DEBUG > dev_dbg(&spi->dev, "set: address filtering"); > @@ -816,2 +816,2 @@ int rf69_set_broadcast_address(struct spi_device *spi, u8 > broadcastAddress) > return WRITE_REG(REG_BROADCASTADRS, broadcastAddress); > } > > -int rf69_set_tx_start_condition(struct spi_device *spi, enum > txStartCondition txStartCondition) > +int rf69_set_tx_start_condition(struct spi_device *spi, enum > tx_start_condition txStartCondition) > { > #ifdef DEBUG > dev_dbg(&spi->dev, "set: start condition"); > -- > 2.7.4 > > > _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel