On Wed, Sep 27, 2017 at 12:57:28PM -0500, Ioana Radulescu wrote:
> diff --git a/drivers/staging/fsl-mc/bus/dpio/dpio-service.c
> b/drivers/staging/fsl-mc/bus/dpio/dpio-service.c
> index f809682..26922fc 100644
> --- a/drivers/staging/fsl-mc/bus/dpio/dpio-service.c
> +++ b/drivers/staging/fsl-mc/bus/dpio/dpio-service.c
> @@ -76,7 +76,7 @@ static inline struct dpaa2_io *service_select_by_cpu(struct
> dpaa2_io *d,
> if (d)
> return d;
>
> - if (unlikely(cpu >= num_possible_cpus()))
> + if (unlikely(cpu >= (int)num_possible_cpus()))
Drivers shouldn't use likely/unlikley. Please write it more explicitly
like this:
if (cpu != -1 && cpu >= num_possible_cpus())
return NULL;
Same for the other one as well.
regards,
dan carpenter
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
