[PATCH 2/3] Staging: gdm724x: tty: Remove unnecessary macro 'gdm_tty_recv'.

[Quytelda Kahja]

Remove the macro 'gdm_tty_recv' which adds unnecessary complexity and has
arguments that could mistakenly be evaluated multiple times.

Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
 drivers/staging/gdm724x/gdm_tty.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/gdm724x/gdm_tty.c 
b/drivers/staging/gdm724x/gdm_tty.c
index 1c3853bcfac2..25357dc3d88c 100644
--- a/drivers/staging/gdm724x/gdm_tty.c
+++ b/drivers/staging/gdm724x/gdm_tty.c
@@ -37,8 +37,6 @@
 
 #define MUX_TX_MAX_SIZE 2048
 
-#define gdm_tty_recv(n, c) (\
-       n->tty_dev->recv_func(n->tty_dev->priv_dev, c))
 #define gdm_tty_send_control(n, r, v, d, l) (\
        n->tty_dev->send_control(n->tty_dev->priv_dev, r, v, d, l))
 
@@ -144,7 +142,8 @@ static int gdm_tty_recv_complete(void *data,
 
        if (!GDM_TTY_READY(gdm)) {
                if (complete == RECV_PACKET_PROCESS_COMPLETE)
-                       gdm_tty_recv(gdm, gdm_tty_recv_complete);
+                       gdm->tty_dev->recv_func(gdm->tty_dev->priv_dev,
+                                               gdm_tty_recv_complete);
                return TO_HOST_PORT_CLOSE;
        }
 
@@ -158,7 +157,8 @@ static int gdm_tty_recv_complete(void *data,
        }
 
        if (complete == RECV_PACKET_PROCESS_COMPLETE)
-               gdm_tty_recv(gdm, gdm_tty_recv_complete);
+               gdm->tty_dev->recv_func(gdm->tty_dev->priv_dev,
+                                       gdm_tty_recv_complete);
 
        return 0;
 }
@@ -253,7 +253,8 @@ int register_lte_tty_device(struct tty_dev *tty_dev, struct 
device *device)
        }
 
        for (i = 0; i < MAX_ISSUE_NUM; i++)
-               gdm_tty_recv(gdm, gdm_tty_recv_complete);
+               gdm->tty_dev->recv_func(gdm->tty_dev->priv_dev,
+                                       gdm_tty_recv_complete);
 
        return 0;
 }
-- 
2.16.1

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel