Another ancient patch....
On Sun, Oct 02 2016, James Simmons wrote: > From: John L. Hammond <john.hamm...@intel.com> > > During development a new api, cl_object_obd_info_get() > and cl_object_data_version() which then were later > replaced by a better solution CIT_DATA_VERSION. For > the case of the upstream client their is no point in > introducing a API to only have it removed later. Due > to the way the patches landed with their dependencies > it is not possible to separate out two patches. These > two combined patches do the following: > > * Add a new cl_io type CIT_DATA_VERSION to get file > data version. > * Remove the unused IOC_LOV_GETINFO ioctl. > * Remove ll_glimpse_ioctl() and ll_lsm_getattr(). > * Remove the OBD API method obd_getattr_async(). > > Signed-off-by: John L. Hammond <john.hamm...@intel.com> > Signed-off-by: Bobi Jam <bobijam...@intel.com> > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5823 > Reviewed-on: http://review.whamcloud.com/12748 > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6356 > Reviewed-on: http://review.whamcloud.com/14649 > Reviewed-by: Henri Doreau <henri.dor...@cea.fr> > Reviewed-by: Jinshan Xiong <jinshan.xi...@intel.com> > Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> > Signed-off-by: James Simmons <jsimm...@infradead.org> With so many Reviewed-by :-) > > +static void > +lov_io_data_version_end(const struct lu_env *env, const struct cl_io_slice > *ios) > +{ > + struct lov_io *lio = cl2lov_io(env, ios); > + struct cl_io *parent = lio->lis_cl.cis_io; > + struct lov_io_sub *sub; > + > + list_for_each_entry(sub, &lio->lis_active, sub_linkage) { > + lov_io_end_wrapper(env, sub->sub_io); This sort of construct occurs several other times in the same file: lov_io_read_ahead: rc = cl_io_read_ahead(sub->sub_env, sub->sub_io, lov_io_submit: rc = cl_io_submit_rw(sub->sub_env, sub->sub_io, crt, queue); lio_io_commit_async: rc = cl_io_commit_async(sub->sub_env, sub->sub_io, queue, from, to, cb); lov_io_fsync_end: struct cl_io *subio = sub->sub_io; lov_io_end_wrapper(sub->sub_env, subio); Every other time, sub->sub_env is used with sub->sub_io. In this new code, 'env' is (incorrectly) used with sub->sub_io. This reliably causes my testing to crash as the LNVRNT() in cl2osc_io() fails, and I test with CONFIG_LUSTRE_DEBUG_EXPENSIVE_CHECK=y Does anyone have any idea why no other testing trips over this? lustre-release has the same bug in Commit: fcd45488711a ("LU-5683 clio: add CIT_DATA_VERSION") I'll send a patch for Linux. Someone else might like to fix lustre-release. Thanks, NeilBrown
signature.asc
Description: PGP signature
_______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
