Adjust a switch block to explicitly match channels and
return -EINVAL as default case which makes the code
semantically more clear.

Signed-off-by: Shreeya Patel <shreeya.patel23...@gmail.com>
---

Changes in v3
  -After split patch.

 drivers/staging/iio/accel/adis16209.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/iio/accel/adis16209.c 
b/drivers/staging/iio/accel/adis16209.c
index eb5c878..9cb1ce0 100644
--- a/drivers/staging/iio/accel/adis16209.c
+++ b/drivers/staging/iio/accel/adis16209.c
@@ -155,10 +155,16 @@ static int adis16209_read_raw(struct iio_dev *indio_dev,
                switch (chan->type) {
                case IIO_VOLTAGE:
                        *val = 0;
-                       if (chan->channel == 0)
+                       switch (chan->channel) {
+                       case 0:
                                *val2 = 305180; /* 0.30518 mV */
-                       else
+                               break;
+                       case 1:
                                *val2 = 610500; /* 0.6105 mV */
+                               break;
+                       default:
+                               return -EINVAL;
+                       }
                        return IIO_VAL_INT_PLUS_MICRO;
                case IIO_TEMP:
                        *val = -470;
-- 
2.7.4

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to