On Tue, Mar 13, 2018 at 11:57:35AM +0100, Sergio Paracuellos wrote:
> On Tue, Mar 13, 2018 at 11:04 AM, Dan Carpenter
> <dan.carpen...@oracle.com> wrote:
> > It takes a long time to review this, not because it's hard but because
> > I have to look at each line and think "Is this really a worthwhile line
> > to keep?" and a lot of them are marginal but perhaps not necessarily
> > bad?
> I see. I though if they were there, it might be useful traces for
> somebody in any kind of way :-).

Yeah.  I know, right?  It feels like the original author must have
thought they were super useful and you and I probably don't even have
this hardware (I don't) so it feels wrong to delete too much stuff...

But it's probably the right thing.

I can bet that I will automatically approve of almost anything error
message deletion but it's hard for me to delete the stuff myself because
I am a hoarder by nature.

dan carpenter

devel mailing list

Reply via email to