On 26.03.2018 22:41, Julia Lawall wrote:
> From: Fengguang Wu <fengguang...@intel.com>
> 
> drivers/staging/wilc1000/host_interface.c:946:32-39: WARNING opportunity for 
> kmemdup
> drivers/staging/wilc1000/host_interface.c:970:30-37: WARNING opportunity for 
> kmemdup
> 
>  Use kmemdup rather than duplicating its implementation
> 
> Generated by: scripts/coccinelle/api/memdup.cocci
> 
> Fixes: aaea2164bdff ("staging: wilc1000: check for kmalloc allocation 
> failures")
> CC: Colin Ian King <colin.k...@canonical.com>
> Signed-off-by: Fengguang Wu <fengguang...@intel.com>
> Signed-off-by: Julia Lawall <julia.law...@lip6.fr>

Reviewed-by: Claudiu Beznea <claudiu.bez...@microchip.com>

> ---
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> staging-next
> head:   12a0148711a440f5b7111f95a34dfce88cdb47d6
> commit: aaea2164bdff39697d0f1ec69dcae62632e37974 [400/412] staging:
> wilc1000: check for kmalloc allocation failures
> 
> In the first hunk, should 6 be ETH_ALEN?

Yes, it should be so.

> 
>  host_interface.c |   10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -943,12 +943,12 @@ static s32 handle_connect(struct wilc_vi
>       }
> 
>       if (conn_attr->bssid) {
> -             hif_drv->usr_conn_req.bssid = kmalloc(6, GFP_KERNEL);
> +             hif_drv->usr_conn_req.bssid = kmemdup(conn_attr->bssid, 6,
> +                                                   GFP_KERNEL);
>               if (!hif_drv->usr_conn_req.bssid) {
>                       result = -ENOMEM;
>                       goto error;
>               }
> -             memcpy(hif_drv->usr_conn_req.bssid, conn_attr->bssid, 6);
>       }
> 
>       hif_drv->usr_conn_req.ssid_len = conn_attr->ssid_len;
> @@ -967,15 +967,13 @@ static s32 handle_connect(struct wilc_vi
> 
>       hif_drv->usr_conn_req.ies_len = conn_attr->ies_len;
>       if (conn_attr->ies) {
> -             hif_drv->usr_conn_req.ies = kmalloc(conn_attr->ies_len,
> +             hif_drv->usr_conn_req.ies = kmemdup(conn_attr->ies,
> +                                                 conn_attr->ies_len,
>                                                   GFP_KERNEL);
>               if (!hif_drv->usr_conn_req.ies) {
>                       result = -ENOMEM;
>                       goto error;
>               }
> -             memcpy(hif_drv->usr_conn_req.ies,
> -                    conn_attr->ies,
> -                    conn_attr->ies_len);
>       }
> 
>       hif_drv->usr_conn_req.security = conn_attr->security;
> _______________________________________________
> devel mailing list
> de...@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> 
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to