> -----Original Message----- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Andrew Lunn > Sent: Tuesday, March 27, 2018 4:38 PM > To: Razvan Stefanescu <razvan.stefane...@nxp.com> > Cc: gre...@linuxfoundation.org; de...@driverdev.osuosl.org; linux- > ker...@vger.kernel.org; net...@vger.kernel.org; Alexandru Marginean > <alexandru.margin...@nxp.com>; Ruxandra Ioana Ciocoi Radulescu > <ruxandra.radule...@nxp.com>; Ioana Ciornei <ioana.cior...@nxp.com>; > Laurentiu Tudor <laurentiu.tu...@nxp.com>; stuyo...@gmail.com > Subject: Re: [PATCH] staging: fsl-dpaa2/ethsw: Fix TCI values overwrite > > On Tue, Mar 27, 2018 at 08:10:50AM -0500, Razvan Stefanescu wrote: > > Previous implementation overwrites PCP value, assuming the default value > is > > 0, instead of 7. > > > > Avoid this by modifying helper function ethsw_port_set_tci() to > > ethsw_port_set_pvid() and make it update only the vlan_id of the tci_cfg > > struct. > > Hi Razvan > > It is a good idea to explain acronyms, especially for staging, since > there are patches for all sorts of devices, can you cannot expect > everybody to know network specific acronyms. > > By PCP you mean Priority Code Point. TCI i have no idea about. > > Looking at the code, i think you are changing the flow to become > read/modify/write, instead of just write, which is overwriting the > previously configured Priority Code Point? > > Please try to add more details to your change logs, to help us > understand the change. >
Thank you Andrew. I'll address this in v2. Best regards, Razvan Stefanescu _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
