Hi Fernando, Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.17-rc1 next-20180417] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Fernando-Pereira/staging-ks7010-Fix-coding-style-issues/20180417-190035 config: parisc-allmodconfig (attached as .config) compiler: hppa-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=parisc All errors (new ones prefixed by >>): drivers/staging/ks7010/ks_wlan_net.c: In function 'ks_wlan_set_freq': >> drivers/staging/ks7010/ks_wlan_net.c:238:1: error: unable to generate >> reloads for: } ^ (insn 80 79 242 4 (set (reg:DF 145 [ _4 ]) (float:DF (reg/v:SI 150 [ c ]))) "drivers/staging/ks7010/ks_wlan_net.c":209 98 {floatsidf2} (nil)) drivers/staging/ks7010/ks_wlan_net.c:238:1: internal compiler error: in find_reloads, at reload.c:3822 Please submit a full bug report, with preprocessed source if appropriate. See <file:///usr/share/doc/gcc-7/README.Bugs> for instructions. vim +238 drivers/staging/ks7010/ks_wlan_net.c 13a9930d Wolfram Sang 2016-05-31 195 1df65547 Wolfram Sang 2016-05-31 196 static int ks_wlan_set_freq(struct net_device *dev, 1df65547 Wolfram Sang 2016-05-31 197 struct iw_request_info *info, struct iw_freq *fwrq, 1df65547 Wolfram Sang 2016-05-31 198 char *extra) 13a9930d Wolfram Sang 2016-05-31 199 { 2b0d92b2 Tobin C. Harding 2017-04-27 200 struct ks_wlan_private *priv = netdev_priv(dev); ba932876 Tobin C. Harding 2017-04-10 201 int channel; 13a9930d Wolfram Sang 2016-05-31 202 6b750fac Muraru Mihaela 2016-10-04 203 if (priv->sleep_mode == SLP_SLEEP) 1df65547 Wolfram Sang 2016-05-31 204 return -EPERM; 13a9930d Wolfram Sang 2016-05-31 205 1df65547 Wolfram Sang 2016-05-31 206 /* for SLEEP MODE */ 13a9930d Wolfram Sang 2016-05-31 207 /* If setting by frequency, convert to a channel */ 13a9930d Wolfram Sang 2016-05-31 208 if ((fwrq->e == 1) && 89a9d50b Fernando Pereira 2018-04-16 209 (fwrq->m >= 2.412e8) && (fwrq->m <= 2.487e8)) { 13a9930d Wolfram Sang 2016-05-31 210 int f = fwrq->m / 100000; 13a9930d Wolfram Sang 2016-05-31 211 int c = 0; fe497530 Yamanappagouda Patil 2016-12-03 212 13a9930d Wolfram Sang 2016-05-31 213 while ((c < 14) && (f != frequency_list[c])) 13a9930d Wolfram Sang 2016-05-31 214 c++; 13a9930d Wolfram Sang 2016-05-31 215 /* Hack to fall through... */ 13a9930d Wolfram Sang 2016-05-31 216 fwrq->e = 0; 13a9930d Wolfram Sang 2016-05-31 217 fwrq->m = c + 1; 13a9930d Wolfram Sang 2016-05-31 218 } 13a9930d Wolfram Sang 2016-05-31 219 /* Setting by channel number */ ba932876 Tobin C. Harding 2017-04-10 220 if ((fwrq->m > 1000) || (fwrq->e > 0)) 13b05e46 Tobin C. Harding 2017-03-21 221 return -EOPNOTSUPP; ba932876 Tobin C. Harding 2017-04-10 222 ba932876 Tobin C. Harding 2017-04-10 223 channel = fwrq->m; 13a9930d Wolfram Sang 2016-05-31 224 /* We should do a better check than that, 64068bc3 Tobin C. Harding 2017-03-14 225 * based on the card capability !!! 64068bc3 Tobin C. Harding 2017-03-14 226 */ 13a9930d Wolfram Sang 2016-05-31 227 if ((channel < 1) || (channel > 14)) { ba932876 Tobin C. Harding 2017-04-10 228 netdev_dbg(dev, "%s: New channel value of %d is invalid!\n", 1df65547 Wolfram Sang 2016-05-31 229 dev->name, fwrq->m); 13b05e46 Tobin C. Harding 2017-03-21 230 return -EINVAL; ba932876 Tobin C. Harding 2017-04-10 231 } ba932876 Tobin C. Harding 2017-04-10 232 13a9930d Wolfram Sang 2016-05-31 233 /* Yes ! We can set it !!! */ 13a9930d Wolfram Sang 2016-05-31 234 priv->reg.channel = (u8)(channel); 13a9930d Wolfram Sang 2016-05-31 235 priv->need_commit |= SME_MODE_SET; 13a9930d Wolfram Sang 2016-05-31 236 13b05e46 Tobin C. Harding 2017-03-21 237 return -EINPROGRESS; /* Call commit handler */ 13a9930d Wolfram Sang 2016-05-31 @238 } 13a9930d Wolfram Sang 2016-05-31 239 :::::: The code at line 238 was first introduced by commit :::::: 13a9930d15b424ab7d3b906af8ba7ff8c409edfe staging: ks7010: add driver from Nanonote extra-repository :::::: TO: Wolfram Sang <wsa+rene...@sang-engineering.com> :::::: CC: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
_______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
