On Sun, Apr 22, 2018 at 03:47:24AM +0530, Souptick Joarder wrote:
> @@ -261,7 +261,7 @@ static inline int to_fault_error(int result)
>   * \retval VM_FAULT_ERROR on general error
>   * \retval NOPAGE_OOM not have memory for allocate new page
>   */
> -static int ll_fault0(struct vm_area_struct *vma, struct vm_fault *vmf)
> +static vm_fault_t ll_fault0(struct vm_area_struct *vma, struct vm_fault *vmf)
>  {
>       struct lu_env      *env;
>       struct cl_io        *io;

Did you compile-test this with the sparse changes?  Because I can see
a problem here:

        env = cl_env_get(&refcheck);
        if (IS_ERR(env))
                return PTR_ERR(env);

> @@ -269,7 +269,7 @@ static int ll_fault0(struct vm_area_struct *vma, struct 
> vm_fault *vmf)
>       struct page          *vmpage;
>       unsigned long       ra_flags;
>       int                   result = 0;
> -     int                   fault_ret = 0;
> +     vm_fault_t              fault_ret = 0;

What odd indentation ...

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to