Hey K. Y,

Currently, while reporting the panic message, we don't have a check for the 
extra MSR capability. It 
key's off of the existing crash MSR bit. There are no operational issues with 
it. But, after some
discussions with John, for consistency purposes, the suggestion was to check 
for the additional bit
as well. Hold on to the patch for now, I will have a V4 with the changes.

- Sunil

> -----Original Message-----
> From: KY Srinivasan
> Sent: Wednesday, May 30, 2018 12:43 PM
> To: Sunil Muthuswamy <sunil...@microsoft.com>; Greg KH
> <gre...@linuxfoundation.org>; Haiyang Zhang <haiya...@microsoft.com>;
> Stephen Hemminger <sthem...@microsoft.com>
> Cc: de...@linuxdriverproject.org
> Subject: RE: [PATCH v1] Drivers: HV: Send one page worth of kmsg dump
> over Hyper-V during panic
> 
> 
> 
> > -----Original Message-----
> > From: Sunil Muthuswamy
> > Sent: Wednesday, May 30, 2018 12:40 PM
> > To: Greg KH <gre...@linuxfoundation.org>; Haiyang Zhang
> > <haiya...@microsoft.com>; Stephen Hemminger
> > <sthem...@microsoft.com>; KY Srinivasan <k...@microsoft.com>
> > Cc: de...@linuxdriverproject.org
> > Subject: RE: [PATCH v1] Drivers: HV: Send one page worth of kmsg dump
> > over Hyper-V during panic
> >
> > The maintainers of Hyper-V; Haiyang Zhang and Stephen Hemminger have
> > always been included since the beginning in all mail & patches. I missed K.
> Y.
> > Srinivasan, whom I have added now.
> 
> I will take this patch through my tree.
> 
> K. Y
> 
> 
> >
> > @KY Srinivasan, @Stephen Hemminger, @Haiyang Zhang - Can we get
> some
> > reviews/sign-offs?
> >
> > Thanks,
> > Sunil
> >
> > > -----Original Message-----
> > > From: Greg KH <gre...@linuxfoundation.org>
> > > Sent: Tuesday, May 29, 2018 9:43 PM
> > > To: Sunil Muthuswamy <sunil...@microsoft.com>
> > > Cc: de...@linuxdriverproject.org; Haiyang Zhang
> > > <haiya...@microsoft.com>; Stephen Hemminger
> > > <sthem...@microsoft.com>
> > > Subject: Re: [PATCH v1] Drivers: HV: Send one page worth of kmsg dump
> > > over Hyper-V during panic
> > >
> > > On Wed, May 30, 2018 at 06:42:14AM +0200, Greg KH wrote:
> > > > On Tue, May 29, 2018 at 08:11:40PM +0000, Sunil Muthuswamy wrote:
> > > > > The V3 patch should address the concerns/comments below. Happy
> to
> > > > > address any additional comments, if there are any.
> > > >
> > > > Why not respond to the v3 patch so I don't have to go dig it up?  :)
> > > >
> > > > And really, it's up to the maintainer of this subsystem to provide the
> > > > final review, and that's not me.  Why did you not cc: them on the patch
> > > > in the beginning?
> > >
> > > And as proof of that, I don't even have this patch in my "to-review"
> > > local queue as I assumed the hyperv maintainers would take care of it.
> > >
> > > thanks,
> > >
> > > greg k-h
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to