> From: Haiyang Zhang
> Sent: Friday, May 25, 2018 12:52
> To: Dexuan Cui <de...@microsoft.com>; Lorenzo Pieralisi
> <lorenzo.pieral...@arm.com>; Bjorn Helgaas <bhelg...@google.com>;
> linux-...@vger.kernel.org; KY Srinivasan <k...@microsoft.com>; Stephen
> Hemminger <sthem...@microsoft.com>; o...@aepfle.de;
> a...@canonical.com; jasow...@redhat.com
> Cc: linux-ker...@vger.kernel.org; driverdev-devel@linuxdriverproject.org;
> vkuzn...@redhat.com; marcelo.ce...@canonical.com
> Subject: RE: [PATCH] PCI: hv: Fix a __local_bh_enable_ip warning in
> hv_compose_msi_msg()
>
> > From: Dexuan Cui
> > Sent: Tuesday, May 22, 2018 8:18 PM
> > To: Lorenzo Pieralisi <lorenzo.pieral...@arm.com>; Bjorn Helgaas
> > <bhelg...@google.com>; linux-...@vger.kernel.org; KY Srinivasan
> > <k...@microsoft.com>; Stephen Hemminger <sthem...@microsoft.com>;
> > o...@aepfle.de; a...@canonical.com; jasow...@redhat.com
> > Cc: linux-ker...@vger.kernel.org; driverdev-devel@linuxdriverproject.org;
> > Haiyang Zhang <haiya...@microsoft.com>; vkuzn...@redhat.com;
> > marcelo.ce...@canonical.com
> > Subject: [PATCH] PCI: hv: Fix a __local_bh_enable_ip warning in
> > hv_compose_msi_msg()
> >
> >
> > Commit de0aa7b2f97d ("PCI: hv: Fix 2 hang issues in
> hv_compose_msi_msg()")
> > uses local_bh_disable()/enable(), because hv_pci_onchannelcallback() can
> also
> > run in tasklet context as the channel event callback.
> >
> > With CONFIG_PROVE_LOCKING=y in the latest mainline, or old kernels that
> > don't have commit f71b74bca637 ("irq/softirqs: Use lockdep to assert IRQs
> are
> > disabled/enabled"), it turns out can we trigger a warning at the beginning
> > of
> > __local_bh_enable_ip(), because the upper layer irq code can call
> > hv_compose_msi_msg() with local irqs disabled.
> >
> > Let's fix the warning by switching to local_irq_save()/restore(). This is
> > not an
> > issue because hv_pci_onchannelcallback() is not slow, and it not a hot path.
> >
> > Fixes: de0aa7b2f97d ("PCI: hv: Fix 2 hang issues in hv_compose_msi_msg()")
> > Signed-off-by: Dexuan Cui <de...@microsoft.com>
> > Cc: <sta...@vger.kernel.org>
> > Cc: Stephen Hemminger <sthem...@microsoft.com>
> > Cc: K. Y. Srinivasan <k...@microsoft.com>
> > ---
>
> Reviewed-by: Haiyang Zhang <haiya...@microsoft.com>
>
> Thanks you.
Hi Lorenzo,
Can I have your reply to this patch?
-- Dexuan
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
