On Tue, Jun 19, 2018 at 08:56:03PM +0100, John Whitmore wrote:
> @@ -734,16 +734,15 @@ void HTConstructRT2RTAggElement(struct ieee80211_device
> *ieee, u8 *posRT2RTAgg,
> #ifdef TODO
> #if (HAL_CODE_BASE == RTL8192 && DEV_BUS_TYPE == USB_INTERFACE)
> /*
> - //Emily. If it is required to Ask Realtek AP to send AMPDU during AES
> mode, enable this
> - section of code.
> + * Emily. If it is required to Ask Realtek AP to send AMPDU during AES
> + * mode, enable this section of code.
> + */
> +#if 0
> if(IS_UNDER_11N_AES_MODE(Adapter))
> - {
> posRT2RTAgg->Octet[5] |=RT_HT_CAP_USE_AMPDU;
> - }else
> - {
> + else
> posRT2RTAgg->Octet[5] &= 0xfb;
> - }
> - */
> +#endif
> #else
> // Do Nothing
> #endif
Please don't introduce new #if 0 blocks. We should just be deleting
ifdeffed out code. It's an almost mindless task. And anyway the #ifdef
TODO works as an #if 0 anyway so this will never be compiled.
regards,
dan carpenter
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
