[PATCH] Drivers: HV: Fix the issue with freeing up hv_ctl_table_hdr

[Sunil Muthuswamy]

The check to free the Hyper-V control table header was reversed. This
fixes it.

Fixes: 81b18bce48af ("Drivers: HV: Send one page worth of kmsg dump over 
Hyper-V during panic")

Signed-off-by: Sunil Muthuswamy <sunil...@microsoft.com>
---
 drivers/hv/vmbus_drv.c | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index 05e37283d7c3..9380f115095b 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -1179,11 +1179,8 @@ static int vmbus_bus_init(void)
 
        bus_unregister(&hv_bus);
        free_page((unsigned long)hv_panic_page);
-       if (!hv_ctl_table_hdr) {
-               unregister_sysctl_table(hv_ctl_table_hdr);
-               hv_ctl_table_hdr = NULL;
-       }
-
+       unregister_sysctl_table(hv_ctl_table_hdr);
+       hv_ctl_table_hdr = NULL;
        return ret;
 }
 
@@ -1894,11 +1891,8 @@ static void __exit vmbus_exit(void)
        }
 
        free_page((unsigned long)hv_panic_page);
-       if (!hv_ctl_table_hdr) {
-               unregister_sysctl_table(hv_ctl_table_hdr);
-               hv_ctl_table_hdr = NULL;
-       }
-
+       unregister_sysctl_table(hv_ctl_table_hdr);
+       hv_ctl_table_hdr = NULL;
        bus_unregister(&hv_bus);
 
        cpuhp_remove_state(hyperv_cpuhp_online);
-- 
2.17.1

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel