Hi Todd, I love your patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing] [also build test WARNING on v4.19-rc1 next-20180828] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Todd-Kjos/binder-use-standard-functions-to-allocate-fds/20180829-022204 config: i386-randconfig-x016-201834 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): In file included from include/trace/define_trace.h:96:0, from drivers/android/binder_trace.h:408, from drivers/android/binder.c:5781: drivers/android/./binder_trace.h: In function 'trace_raw_output_binder_transaction_fd_send': >> drivers/android/./binder_trace.h:240:12: warning: format '%ld' expects >> argument of type 'long int', but argument 5 has type 'size_t {aka unsigned >> int}' [-Wformat=] TP_printk("transaction=%d src_fd=%d offset=%ld", ^ include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS' trace_seq_printf(s, print); \ ^~~~~ include/trace/trace_events.h:79:9: note: in expansion of macro 'PARAMS' PARAMS(print)); \ ^~~~~~ >> drivers/android/./binder_trace.h:226:1: note: in expansion of macro >> 'TRACE_EVENT' TRACE_EVENT(binder_transaction_fd_send, ^~~~~~~~~~~ >> drivers/android/./binder_trace.h:240:2: note: in expansion of macro >> 'TP_printk' TP_printk("transaction=%d src_fd=%d offset=%ld", ^~~~~~~~~ In file included from include/trace/trace_events.h:394:0, from include/trace/define_trace.h:96, from drivers/android/binder_trace.h:408, from drivers/android/binder.c:5781: drivers/android/./binder_trace.h:240:47: note: format string is defined here TP_printk("transaction=%d src_fd=%d offset=%ld", ~~^ %d In file included from include/trace/define_trace.h:96:0, from drivers/android/binder_trace.h:408, from drivers/android/binder.c:5781: drivers/android/./binder_trace.h: In function 'trace_raw_output_binder_transaction_fd_recv': drivers/android/./binder_trace.h:258:12: warning: format '%ld' expects argument of type 'long int', but argument 5 has type 'size_t {aka unsigned int}' [-Wformat=] TP_printk("transaction=%d dest_fd=%d offset=%ld", ^ include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS' trace_seq_printf(s, print); \ ^~~~~ include/trace/trace_events.h:79:9: note: in expansion of macro 'PARAMS' PARAMS(print)); \ ^~~~~~ drivers/android/./binder_trace.h:244:1: note: in expansion of macro 'TRACE_EVENT' TRACE_EVENT(binder_transaction_fd_recv, ^~~~~~~~~~~ drivers/android/./binder_trace.h:258:2: note: in expansion of macro 'TP_printk' TP_printk("transaction=%d dest_fd=%d offset=%ld", ^~~~~~~~~ In file included from include/trace/trace_events.h:394:0, from include/trace/define_trace.h:96, from drivers/android/binder_trace.h:408, from drivers/android/binder.c:5781: drivers/android/./binder_trace.h:258:48: note: format string is defined here TP_printk("transaction=%d dest_fd=%d offset=%ld", ~~^ %d vim +240 drivers/android/./binder_trace.h 225 > 226 TRACE_EVENT(binder_transaction_fd_send, 227 TP_PROTO(struct binder_transaction *t, int fd, size_t offset), 228 TP_ARGS(t, fd, offset), 229 230 TP_STRUCT__entry( 231 __field(int, debug_id) 232 __field(int, fd) 233 __field(size_t, offset) 234 ), 235 TP_fast_assign( 236 __entry->debug_id = t->debug_id; 237 __entry->fd = fd; 238 __entry->offset = offset; 239 ), > 240 TP_printk("transaction=%d src_fd=%d offset=%ld", 241 __entry->debug_id, __entry->fd, __entry->offset) 242 ); 243 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
_______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
