Hi Stephen, I love your patch! Yet something to improve:
[auto build test ERROR on linus/master] [also build test ERROR on v4.19-rc3 next-20180913] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Stephen-Hemminger/fix-Hyper-V-uio-restart/20180916-181024 config: x86_64-randconfig-x015-201837 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/uio/uio_hv_generic.c: In function 'hv_uio_open': >> drivers/uio/uio_hv_generic.c:214:22: error: 'struct hv_uio_private_data' has >> no member named 'refcount'; did you mean 'refcnt'? atomic_dec(&pdata->refcount); ^~~~~~~~ refcnt vim +214 drivers/uio/uio_hv_generic.c 195 196 /* VMBus primary channel is opened on first use */ 197 static int 198 hv_uio_open(struct uio_info *info, struct inode *inode) 199 { 200 struct hv_uio_private_data *pdata 201 = container_of(info, struct hv_uio_private_data, info); 202 struct hv_device *dev = pdata->device; 203 int ret; 204 205 if (atomic_inc_return(&pdata->refcnt) != 1) 206 return 0; 207 208 ret = vmbus_connect_ring(dev->channel, 209 hv_uio_channel_cb, dev->channel); 210 211 if (ret == 0) 212 dev->channel->inbound.ring_buffer->interrupt_mask = 1; 213 else > 214 atomic_dec(&pdata->refcount); 215 216 return ret; 217 } 218 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
_______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
