On Tue, 2018-11-20 at 10:57 +0100, Greg KH wrote: > On Sun, Nov 18, 2018 at 04:55:49PM +0100, Stefan Wahren wrote: > > Hi Nicolas, > > > > > Nicolas Saenz Julienne <nsaenzjulie...@suse.de> hat am 14. > > > November 2018 um 13:59 geschrieben: > > > > > > > > > Hi All, > > > > > > This series was written in parallel with reading and > > > understanding the > > > vchiq code. So excuse me for the lack of logic in the sequence of > > > patches. > > > > > > The main focus was to delete as much code as possible, I've > > > counted > > > around 550 lines, which is not bad. Apart from that there are > > > some > > > patches enforcing proper kernel APIs usage. > > > > > > The only patch that really changes code is the > > > vchiq_ioc_copy_element_data() rewrite. > > > > > > The last commit updates the TODO list with some of my > > > observations, I > > > realise some of the might be a little opinionated. If anything > > > it's > > > going to force a discussion on the topic, which is nice. > > > > > > It was developed on top of the latest linux-next, and was tested > > > on a > > > RPIv3B+ with audio, video and running vchiq_test. > > > > > > Regards, > > > Nicolas > > > > > > > without a changelog i won't start a review. > > What do you mean by this? The individual patches have a "changelog" > in > them, this is just a summary of the overall changes. > > What do you feel is missing here?
Hi Greg, I did send an RFC version of this, to which Stephan made several comments. I should have added the changelog to the proper series submission. I've been busy with work, but I'll send the updated version during the day. Regards, Nicolas > > thanks, > > greg k-h
signature.asc
Description: This is a digitally signed message part
_______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
