Typedefing structs is not encouraged in the kernel.

The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.

Signed-off-by: Dominic Braun <inf.br...@fau.de>
Signed-off-by: Tobias Büttner <tobias.buett...@fau.de>
---
 .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c   | 4 ++--
 .../staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c 
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
index ea9d678a3f7c..f493322826b3 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
@@ -1040,7 +1040,7 @@ vchiq_ioctl(struct file *file, unsigned int cmd, unsigned 
long arg)
        } break;
 
        case VCHIQ_IOC_QUEUE_MESSAGE: {
-               VCHIQ_QUEUE_MESSAGE_T args;
+               struct vchiq_queue_message_struct args;
 
                if (copy_from_user
                         (&args, (const void __user *)arg,
@@ -1598,7 +1598,7 @@ vchiq_compat_ioctl_queue_message(struct file *file,
                                 unsigned int cmd,
                                 unsigned long arg)
 {
-       VCHIQ_QUEUE_MESSAGE_T *args;
+       struct vchiq_queue_message_struct *args;
        struct vchiq_element __user *elements;
        struct vchiq_queue_message32 args32;
        unsigned int count;
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h 
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h
index b587a395b9c3..bc47e9161dc4 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h
@@ -47,11 +47,11 @@ struct vchiq_create_service_struct {
        unsigned int handle;       /* OUT */
 };
 
-typedef struct {
+struct vchiq_queue_message_struct {
        unsigned int handle;
        unsigned int count;
        const struct vchiq_element __user *elements;
-} VCHIQ_QUEUE_MESSAGE_T;
+};
 
 struct vchiq_queue_bulk_transfer {
        unsigned int handle;
@@ -105,7 +105,7 @@ struct vchiq_dump_mem_struct {
        _IOWR(VCHIQ_IOC_MAGIC, 2, struct vchiq_create_service_struct)
 #define VCHIQ_IOC_REMOVE_SERVICE       _IO(VCHIQ_IOC_MAGIC,   3)
 #define VCHIQ_IOC_QUEUE_MESSAGE \
-       _IOW(VCHIQ_IOC_MAGIC,  4, VCHIQ_QUEUE_MESSAGE_T)
+       _IOW(VCHIQ_IOC_MAGIC,  4, struct vchiq_queue_message_struct)
 #define VCHIQ_IOC_QUEUE_BULK_TRANSMIT \
        _IOWR(VCHIQ_IOC_MAGIC, 5, struct vchiq_queue_bulk_transfer)
 #define VCHIQ_IOC_QUEUE_BULK_RECEIVE \
-- 
2.17.1

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to