On Tue, Dec 11, 2018 at 05:54:56PM -0700, Jeremy Fertic wrote:
> @@ -651,10 +649,12 @@ static ssize_t adt7316_store_da_high_resolution(struct 
> device *dev,
>       u8 config3;
>       int ret;
>  
> +     if (chip->id == ID_ADT7318 || chip->id == ID_ADT7519)
> +             return -EPERM;

return -EINVAL is more appropriate than -EPERM.

regards,
dan carpenter

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to