On Do, 2018-12-13 at 14:54 +0300, Dan Carpenter wrote:
> I'm not really complaining about breaking userspace, I'm complaining
> that I had to discover it by reading the code.  It should have been
> mentioned in the commit message.  We should probably just fold
> patch 1 & 6 together.
> 
Ok, I probably should have mentioned this in the cover letter.
Thought the usage file addition is enough. Sorry for the
inconvenience. 

> I'm also not really complaining about this patch in particular when
> it
> comes to the API.  The whole thing is a bit weird to me.  I wish we
> could re-think the configuration from square one...
> 
> It could be done in a later patch.  I'm not going to NAK this patch
> if
> you resend it with the other small issues fixed.
> 

Greg put configfs on the table. But this is like a total
redesign of the
driver interface which will take some
time.

thanks,
Chris
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to