Hi Amir, Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.20-rc7 next-20181214] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Amir-Mahdi-Ghorbanian/Staging-comedi-cb_pcidas-fixed-a-spelling-mistake-coding-style-issue/20181217-032106 config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=arm All errors (new ones prefixed by >>): drivers/staging/nvec/nvec.c: In function 'nvec_request_master': >> drivers/staging/nvec/nvec.c:385:3: error: 'done' undeclared (first use in >> this function); did you mean 'zone'? done = &nvec->ec_transfer; ^~~~ zone drivers/staging/nvec/nvec.c:385:3: note: each undeclared identifier is reported only once for each function it appears in >> drivers/staging/nvec/nvec.c:386:3: error: 'timeout' undeclared (first use in >> this function); did you mean 'time_t'? timeout = msecs_to_jiffies(5000); ^~~~~~~ time_t vim +385 drivers/staging/nvec/nvec.c 364 365 /** 366 * nvec_request_master - Process outgoing messages 367 * @work: A &struct work_struct (the tx_worker member of &struct nvec_chip) 368 * 369 * Processes all outgoing requests by sending the request and awaiting the 370 * response, then continuing with the next request. Once a request has a 371 * matching response, it will be freed and removed from the list. 372 */ 373 static void nvec_request_master(struct work_struct *work) 374 { 375 struct nvec_chip *nvec = container_of(work, struct nvec_chip, tx_work); 376 unsigned long flags; 377 long err; 378 struct nvec_msg *msg; 379 380 spin_lock_irqsave(&nvec->tx_lock, flags); 381 while (!list_empty(&nvec->tx_data)) { 382 msg = list_first_entry(&nvec->tx_data, struct nvec_msg, node); 383 spin_unlock_irqrestore(&nvec->tx_lock, flags); 384 nvec_gpio_set_value(nvec, 0); > 385 done = &nvec->ec_transfer; > 386 timeout = msecs_to_jiffies(5000); 387 err = wait_for_completion_interruptible_timeout(done, 388 timeout); 389 390 if (err == 0) { 391 dev_warn(nvec->dev, "timeout waiting for ec transfer\n"); 392 nvec_gpio_set_value(nvec, 1); 393 msg->pos = 0; 394 } 395 396 spin_lock_irqsave(&nvec->tx_lock, flags); 397 398 if (err > 0) { 399 list_del_init(&msg->node); 400 nvec_msg_free(nvec, msg); 401 } 402 } 403 spin_unlock_irqrestore(&nvec->tx_lock, flags); 404 } 405 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
_______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
