Hi Bo,
On 2019/2/21 22:28, Bo YU wrote:
> From: Bo Yu <tsu.y...@gmail.com>
>
> Fix sparse warnings:
>
> drivers/staging/erofs/utils.c:134:6: warning: symbol
> 'erofs_try_to_release_workgroup' was not declared. Should it be static?
>
> Fixes: 51232df5e4b26("staging: erofs: fix race when the managed cache is
> enabled")
> Cc: Gao Xiang <gaoxian...@huawei.com>
> Cc: Chao Yu <yuch...@huawei.com>
> CC: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> Signed-off-by: Bo Yu <tsu.y...@gmail.com>
> ---
> drivers/staging/erofs/utils.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/erofs/utils.c b/drivers/staging/erofs/utils.c
> index b535898ca753..33cd5ad55cb8 100644
> --- a/drivers/staging/erofs/utils.c
> +++ b/drivers/staging/erofs/utils.c
> @@ -131,7 +131,7 @@ static void erofs_workgroup_unfreeze_final(struct
> erofs_workgroup *grp)
> __erofs_workgroup_free(grp);
> }
>
> -bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,
> +static bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,
> struct erofs_workgroup *grp,
> bool cleanup)
> {
>
Have you looked the latest kernel code?
It seems erofs_try_to_release_workgroup is already be claimed as static...
See:
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/tree/drivers/staging/erofs/utils.c?h=staging-next#n148
Thanks,
Gao Xiang
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
