Re: [PATCH] staging: rtl8723bs: Resolve checkpatch error "that open brace { should be on the previous line" in the rtl8723bs driver

[Greg Kroah-Hartman]

On Thu, Jun 13, 2019 at 07:12:10PM -0700, Shobhit Kukreti wrote:
> Cleaned up the code from the following files to get rid of
> check patch error "that open brace { should be on the previous line"
> 
> drivers/staging/rtl8723bs/os_dep/mlme_linux.c
> drivers/staging/rtl8723bs/os_dep/recv_linux.c
> drivers/staging/rtl8723bs/os_dep/rtw_proc.c
> drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c
> 
> Signed-off-by: Shobhit Kukreti <shobhitkukr...@gmail.com>
> ---
>  drivers/staging/rtl8723bs/os_dep/mlme_linux.c     | 14 ++---
>  drivers/staging/rtl8723bs/os_dep/recv_linux.c     | 76 
> ++++++++---------------
>  drivers/staging/rtl8723bs/os_dep/rtw_proc.c       |  6 +-
>  drivers/staging/rtl8723bs/os_dep/sdio_intf.c      | 15 ++---
>  drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c | 24 +++----
>  5 files changed, 47 insertions(+), 88 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/mlme_linux.c 
> b/drivers/staging/rtl8723bs/os_dep/mlme_linux.c
> index aa2499f..6799ed4 100644
> --- a/drivers/staging/rtl8723bs/os_dep/mlme_linux.c
> +++ b/drivers/staging/rtl8723bs/os_dep/mlme_linux.c
> @@ -46,8 +46,7 @@ void rtw_os_indicate_connect(struct adapter *adapter)
>       struct mlme_priv *pmlmepriv = &(adapter->mlmepriv);
>  
>       if ((check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) == true) ||
> -             (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true))
> -     {
> +             (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true)) {
>               rtw_cfg80211_ibss_indicate_connect(adapter);
>       }
>       else
> @@ -77,8 +76,8 @@ void rtw_reset_securitypriv(struct adapter *adapter)
>  
>       spin_lock_bh(&adapter->security_key_mutex);
>  
> -     if (adapter->securitypriv.dot11AuthAlgrthm == dot11AuthAlgrthm_8021X)/* 
> 802.1x */
> -     {
> +     if (adapter->securitypriv.dot11AuthAlgrthm == dot11AuthAlgrthm_8021X) { 
> /* 802.1x */
> +
>               /*  Added by Albert 2009/02/18 */
>               /*  We have to backup the PMK information for WiFi PMK Caching 
> test item. */
>               /*  */
> @@ -106,8 +105,8 @@ void rtw_reset_securitypriv(struct adapter *adapter)
>               adapter->securitypriv.ndisencryptstatus = Ndis802_11WEPDisabled;
>  
>       }
> -     else /* reset values in securitypriv */
> -     {
> +     else { /* reset values in securitypriv */
> +     

Trailing whitespace?

The comment should be on a new line, not on the same line.

thanks,

greg k-h
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel