On Wed, Jul 31, 2019 at 08:58:19PM +0000, adham.aboza...@microchip.com wrote: > From: Adham Abozaeid <adham.aboza...@microchip.com> > > wilc_set_wfi_drv_handler and wilc_set_operation_mode sends the same > parameters to the FW, so it's better to combine them together. > > Kept wilc_set_wfi_drv_handler implementation since it sends all the > required parameters, and renamed it to wilc_set_operation_mode to be > more descriptive. > > Signed-off-by: Adham Abozaeid <adham.aboza...@microchip.com> > --- > drivers/staging/wilc1000/wilc_hif.c | 29 ++----------------- > drivers/staging/wilc1000/wilc_hif.h | 5 ++-- > drivers/staging/wilc1000/wilc_netdev.c | 6 ++-- > .../staging/wilc1000/wilc_wfi_cfgoperations.c | 24 +++++++-------- > drivers/staging/wilc1000/wilc_wlan_if.h | 3 +- > 5 files changed, 20 insertions(+), 47 deletions(-)
This patch causes the following build error: drivers/staging/wilc1000/wilc_hif.c: In function wilc_deinit: drivers/staging/wilc1000/wilc_hif.c:1610:2: error: implicit declaration of function wilc_set_wfi_drv_handler [-Werror=implicit-function-declaration] 1610 | wilc_set_wfi_drv_handler(vif, 0, 0, 0); | ^~~~~~~~~~~~~~~~~~~~~~~~ Always test build your patches... _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel