Re: [PATCH 1/5] staging: rtl8723bs: Remove set but not used variable 'i'

[Dan Carpenter]

On Sun, Oct 06, 2019 at 05:09:55PM +0800, zhengbin wrote:
> @@ -689,7 +688,7 @@ static s32 update_attrib(struct adapter *padapter, _pkt 
> *pkt, struct pkt_attrib
>       DBG_COUNTER(padapter->tx_logs.core_tx_upd_attrib);
> 
>       _rtw_open_pktfile(pkt, &pktfile);
> -     i = _rtw_pktfile_read(&pktfile, (u8 *)&etherhdr, ETH_HLEN);
> +     (void)_rtw_pktfile_read(&pktfile, (u8 *)&etherhdr, ETH_HLEN);

Don't add this "(void)" here.  There is no need and it looks ugly.

        _rtw_pktfile_read(&pktfile, (u8 *)&etherhdr, ETH_HLEN);

regards,
dan carpenter

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel