On Thu, Dec 12, 2019 at 09:02:00AM -0600, Scott Schafer wrote:
> On Thu, Dec 12, 2019 at 03:12:06PM +0300, Dan Carpenter wrote:
> > On Wed, Dec 11, 2019 at 12:12:40PM -0600, Scott Schafer wrote:
> > > @@ -351,8 +352,9 @@ static int ql_aen_lost(struct ql_adapter *qdev,
> > > struct mbox_params *mbcp)
> > > mbcp->out_count = 6;
> > >
> > > status = ql_get_mb_sts(qdev, mbcp);
> > > - if (status)
> > > + if (status) {
> > > netif_err(qdev, drv, qdev->ndev, "Lost AEN broken!\n");
> > > + }
> > > else {
> >
> > The close } should be on the same line as the else.
> >
> > > int i;
> > >
> >
> > regards,
> > dan carpenter
>
> this was fixed in patch 22
The truth is that I don't care at all about tiny typos like this, but
in the future then the right way to fix these is to create a separate
patch for this, and the use git rebase to fold it back into this patch.
It's a pretty straight forward process.
regards,
dan carpenter
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
