On Wed, Mar 11, 2020 at 07:28:59PM +0530, Shreeya Patel wrote:
> Remove unnecessary if and else conditions since both are leading to the
> initialization of "phtpriv->ampdu_enable" with the same value.
> 
> Signed-off-by: Shreeya Patel <shreeya.patel23...@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_mlme.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c 
> b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> index 71fcb466019a..48e9faf27321 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> @@ -2772,13 +2772,9 @@ void rtw_update_ht_cap(struct adapter *padapter, u8 
> *pie, uint ie_len, u8 channe
>  
>       /* maybe needs check if ap supports rx ampdu. */
>       if (!(phtpriv->ampdu_enable) && pregistrypriv->ampdu_enable == 1) {
> -             if (pregistrypriv->wifi_spec == 1) {
> -                     /* remove this part because testbed AP should disable 
> RX AMPDU */
> -                     /* phtpriv->ampdu_enable = false; */
> -                     phtpriv->ampdu_enable = true;
> -             } else {
> -                     phtpriv->ampdu_enable = true;
> -             }
> +             /* remove this part because testbed AP should disable RX AMPDU 
> */
> +             /* phtpriv->ampdu_enable = false; */

Please delete this dead code and the related comment.

regards,
dan carpenter

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to