Brian Aker wrote: > Hi! > > On Dec 23, 2009, at 10:12 AM, Monty Taylor wrote: > >> Yeah. The only code that this touched which might cause a performance >> problem is an extra memcpy that happens now when doing show processlist >> - so I _really_ doubt that write performance regression is real. > > What memory copy? The code around show processlist is very tricky because of > how locks are done.
It's after the locking. The copying of the values into local variables happens just as before inside the lock. We create a thread_info object on the stack and then inject that by value into a vector, so there will be an extra copy for that, but it means less convoluted cleanup code right there. So all I'm saying is - if the patch were going to cause regressions, they'd definitely be in the readonly test. In general, I have zero belief in the validity of the read write test. I don't know why it's so variable, but it's just too flaky for me. > Cheers, > -Brian > >> We really need a better write test... >> >> Jay Pipes wrote: >>> Might not be. Pretty close to STDDEV. I'd give it one more run through >>> sysbench. >>> >>> Brian Aker wrote: >>>> Hi! >>>> >>>> So a write performance problem? >>>> >>>> Cheers, >>>> -Brian >>>> >>>> On Dec 23, 2009, at 4:42 AM, drizzle-x4450 wrote: >>>> >>>>> ========================================================================================================= >>>>> >>>>> REGRESSION REPORT >>>>> ========================================================================================================= >>>>> >>>>> MACHINE: drizzle-x4450 >>>>> RUN ID: 766 >>>>> RUN DATE: 2009-12-23T02:37:43.155828 >>>>> WORKLOAD: innodb_1000K_readwrite >>>>> SERVER: drizzled >>>>> VERSION: lp:~mordred/drizzle/remove-ilist >>>>> REVISION: 1252 >>>>> COMMENT: 1252: Monty Taylor 2009-12-23 [merge] Merged trunk. >>>>> ========================================================================================================= >>>>> >>>>> >>>>> TRENDING OVER LAST 5 runs >>>>> Conc TPS % Diff from Avg Diff Norm? Min >>>>> Max Avg STD >>>>> ========================================================================================================= >>>>> >>>>> 2 629.16 +0.70% 4.34 within norms >>>>> 596.07 644.12 624.81 15.67 >>>>> 4 823.89 -12.19% -114.35 within norms >>>>> 782.14 1171.96 938.24 152.11 >>>>> 8 1343.28 -21.82% -374.83 outside norms >>>>> 1317.68 1961.08 1718.12 267.01 >>>>> 16 2004.74 -8.42% -184.34 outside norms >>>>> 1972.28 2448.69 2189.08 181.84 >>>>> 32 2541.56 -5.64% -152.05 outside norms >>>>> 2522.66 2800.12 2693.61 110.52 >>>>> 64 2119.74 -2.22% -48.17 within norms >>>>> 2055.13 2366.53 2167.92 96.75 >>>>> 128 2001.11 -5.87% -124.88 within norms >>>>> 1952.73 2370.65 2125.99 129.52 >>>>> 256 1927.88 -2.11% -41.46 within norms >>>>> 1845.89 2086.93 1969.35 77.21 >>>>> 512 1758.00 -0.69% -12.14 within norms >>>>> 1751.79 1790.62 1770.14 14.26 >>>>> 1024 980.60 +0.66% 6.39 within norms >>>>> 961.39 982.50 974.21 7.08 >>>>> ========================================================================================================= >>>>> >>>>> >>>>> TRENDING OVER Last 20 runs >>>>> >>>>> Conc TPS % Diff from Avg Diff Norm? Min >>>>> Max Avg STD >>>>> ========================================================================================================= >>>>> >>>>> 2 629.16 +0.70% 4.34 within norms >>>>> 596.07 644.12 624.81 15.67 >>>>> 4 823.89 -12.19% -114.35 within norms >>>>> 782.14 1171.96 938.24 152.11 >>>>> 8 1343.28 -21.82% -374.83 outside norms >>>>> 1317.68 1961.08 1718.12 267.01 >>>>> 16 2004.74 -8.42% -184.34 outside norms >>>>> 1972.28 2448.69 2189.08 181.84 >>>>> 32 2541.56 -5.64% -152.05 outside norms >>>>> 2522.66 2800.12 2693.61 110.52 >>>>> 64 2119.74 -2.22% -48.17 within norms >>>>> 2055.13 2366.53 2167.92 96.75 >>>>> 128 2001.11 -5.87% -124.88 within norms >>>>> 1952.73 2370.65 2125.99 129.52 >>>>> 256 1927.88 -2.11% -41.46 within norms >>>>> 1845.89 2086.93 1969.35 77.21 >>>>> 512 1758.00 -0.69% -12.14 within norms >>>>> 1751.79 1790.62 1770.14 14.26 >>>>> 1024 980.60 +0.66% 6.39 within norms >>>>> 961.39 982.50 974.21 7.08 >>>>> ========================================================================================================= >>>>> >>>>> >>>>> TRENDING OVER ALL runs >>>>> >>>>> Conc TPS % Diff from Avg Diff Norm? Min >>>>> Max Avg STD >>>>> ========================================================================================================= >>>>> >>>>> 2 629.16 +0.70% 4.34 within norms >>>>> 596.07 644.12 624.81 15.67 >>>>> 4 823.89 -12.19% -114.35 within norms >>>>> 782.14 1171.96 938.24 152.11 >>>>> 8 1343.28 -21.82% -374.83 outside norms >>>>> 1317.68 1961.08 1718.12 267.01 >>>>> 16 2004.74 -8.42% -184.34 outside norms >>>>> 1972.28 2448.69 2189.08 181.84 >>>>> 32 2541.56 -5.64% -152.05 outside norms >>>>> 2522.66 2800.12 2693.61 110.52 >>>>> 64 2119.74 -2.22% -48.17 within norms >>>>> 2055.13 2366.53 2167.92 96.75 >>>>> 128 2001.11 -5.87% -124.88 within norms >>>>> 1952.73 2370.65 2125.99 129.52 >>>>> 256 1927.88 -2.11% -41.46 within norms >>>>> 1845.89 2086.93 1969.35 77.21 >>>>> 512 1758.00 -0.69% -12.14 within norms >>>>> 1751.79 1790.62 1770.14 14.26 >>>>> 1024 980.60 +0.66% 6.39 within norms >>>>> 961.39 982.50 974.21 7.08 >>>>> ========================================================================================================= >>>>> >>>>> FULL REVISION COMMENTARY: >>>>> >>>>> 1245.1.6: Brian Aker 2009-12-21 [merge] Merging in massif option to >>>>> test-r... >>>>> 1247.1.1: Stewart Smith 2009-12-21 add option to test-run.pl to >>>>> run with... >>>>> 1245.1.5: Brian Aker 2009-12-21 [merge] Merge Monty >>>>> 1241.9.40: Monty Taylor 2009-12-21 Fixed OSX. >>>>> 1241.9.39: Monty Taylor 2009-12-21 Added a few extra includes for >>>>> Solaris. >>>>> 1241.9.38: Monty Taylor 2009-12-21 Ho-ho. There were a bunch of >>>>> files th... >>>>> 1241.9.37: Monty Taylor 2009-12-21 Removed the server_includes.h >>>>> and glo... >>>>> 1241.9.36: Monty Taylor 2009-12-21 ZOMG. I deleted >>>>> drizzled/server_inclu... >>>>> 1241.9.35: Monty Taylor 2009-12-21 Removed the last bits of >>>>> server_inclu... >>>>> 1241.9.34: Monty Taylor 2009-12-21 Removed errmsg_printf from >>>>> server_inc... >>>>> 1241.9.33: Monty Taylor 2009-12-21 Moved most of the global vars >>>>> to set_... >>>>> 1241.9.32: Monty Taylor 2009-12-21 Moved global myisam and heap >>>>> pointers... >>>>> 1241.9.31: Monty Taylor 2009-12-21 Moved global pthread variables >>>>> into t... >>>>> 1241.9.30: Monty Taylor 2009-12-21 More cruft gone. >>>>> 1241.9.29: Monty Taylor 2009-12-21 Removed some globals from >>>>> server_incl... >>>>> 1241.9.28: Monty Taylor 2009-12-21 Removed global_charset_info.h >>>>> from se... >>>>> 1241.9.27: Monty Taylor 2009-12-21 Removed mysys/m_sys.h from >>>>> server_inc... >>>>> 1241.9.26: Monty Taylor 2009-12-20 Removed forward declares from >>>>> server_... >>>>> 1241.9.25: Monty Taylor 2009-12-20 Removed global LEX_STRING ref >>>>> from se... >>>>> 1241.9.24: Monty Taylor 2009-12-20 Removed m_string.h from >>>>> server_includ... >>>>> 1241.9.23: Monty Taylor 2009-12-20 Removed sql_table.h from >>>>> server_inclu... >>>>> 1241.9.22: Monty Taylor 2009-12-20 Removed some bits from >>>>> drizzled/commo... >>>>> 1241.9.21: Monty Taylor 2009-12-20 Removed sql_string.h from >>>>> server_incl... >>>>> 1241.9.20: Monty Taylor 2009-12-20 Removed global sql_list.h include. >>>>> 1241.9.19: Monty Taylor 2009-12-20 Removed global cstdlib include. >>>>> 1241.9.18: Monty Taylor 2009-12-20 Removed global string. >>>>> 1241.9.17: Monty Taylor 2009-12-20 Removed more bits from >>>>> server_includes. >>>>> 1241.9.16: Monty Taylor 2009-12-20 Removed global bitsets. >>>>> 1241.9.15: Monty Taylor 2009-12-20 Moved last of the global >>>>> function dec... >>>>> 1241.9.14: Monty Taylor 2009-12-20 Removed things from >>>>> server_includes.h. >>>>> 1241.9.13: Monty Taylor 2009-12-20 [merge] Merged latest out-of-tree. >>>>> 1241.12.10: Monty Taylor 2009-12-19 [merge] One more time. >>>>> 1241.13.8: Monty Taylor 2009-12-19 Put in a line to remove old >>>>> cruft... >>>>> 1241.12.9: Monty Taylor 2009-12-19 [merge] Merged from me. >>>>> 1241.14.2: Monty Taylor 2009-12-17 Removed virtual destructor >>>>> on sql... >>>>> 1241.14.1: Monty Taylor 2009-12-17 [merge] Merged latest >>>>> header fixe... >>>>> 1241.12.8: Monty Taylor 2009-12-19 [merge] Merged with latest >>>>> header-f... >>>>> 1241.13.7: Monty Taylor 2009-12-19 [merge] Merged with trunk. >>>>> 1241.13.6: Monty Taylor 2009-12-17 Fixed solaris build. >>>>> 1241.12.7: Monty Taylor 2009-12-17 [merge] Merged up latest >>>>> header-fixes. >>>>> 1241.13.5: Monty Taylor 2009-12-17 Wow. This script was SO not >>>>> /bin/sh. >>>>> 1241.13.4: Monty Taylor 2009-12-17 Fixed FreeBSD nonsense. >>>>> 1241.13.3: Monty Taylor 2009-12-17 [merge] Merged trunk. >>>>> 1241.13.2: Monty Taylor 2009-12-17 Merged in change from Trond. >>>>> 1241.12.6: Monty Taylor 2009-12-17 We don't actually support an >>>>> array ... >>>>> 1241.12.5: Monty Taylor 2009-12-15 Replace hand-rolled libm >>>>> check with... >>>>> 1241.12.4: Monty Taylor 2009-12-15 Fixed distcheck. >>>>> 1241.12.3: Monty Taylor 2009-12-15 Fixed missing semi-colons. >>>>> 1241.12.2: Monty Taylor 2009-12-15 [merge] Merged re-addition of >>>>> my_of... >>>>> 1241.13.1: Monty Taylor 2009-12-15 Put my_off_t back... but >>>>> this tim... >>>>> 1241.12.1: Monty Taylor 2009-12-15 Fixed a few plugins. >>>>> 1241.9.12: Monty Taylor 2009-12-20 Trims more out of >>>>> server_includes.h. >>>>> 1241.9.11: Robert Collins 2009-12-20 Fixed a sort order problem >>>>> which wa... >>>>> 1241.9.10: Monty Taylor 2009-12-14 [merge] pandora-build v0.85 - >>>>> Fixed t... >>>>> 1241.11.2: Monty Taylor 2009-12-14 Fixed symlinks. >>>>> 1241.11.1: Monty Taylor 2009-12-14 pandora-build v0.85 - Fixed >>>>> C++ sta... >>>>> 1241.9.9: Monty Taylor 2009-12-14 [merge] Merged in some icc >>>>> warning fix... >>>>> 1240.9.6: Monty Taylor 2009-12-08 Removed some casts- also >>>>> removed a f... >>>>> 1240.9.5: Monty Taylor 2009-12-08 remark #82: storage class is >>>>> not first >>>>> 1240.9.4: Monty Taylor 2009-12-08 destructor for base class >>>>> "Open_tabl... >>>>> 1240.9.3: Monty Taylor 2009-12-08 remark #444: destructor for >>>>> base cla... >>>>> 1240.9.2: Monty Taylor 2009-12-08 Fixed: warning #2203: cast >>>>> discards ... >>>>> 1240.9.1: Monty Taylor 2009-12-08 Fixed: remark #444: destructor >>>>> for b... >>>>> 1241.9.8: Monty Taylor 2009-12-14 [merge] Removed some plugin >>>>> loading cr... >>>>> 1241.10.7: Monty Taylor 2009-12-14 Removed some cruft. >>>>> 1241.10.6: Monty Taylor 2009-12-14 Removed the mem_root from >>>>> plugin::M... >>>>> 1241.10.5: Monty Taylor 2009-12-12 Removed hardcoded option >>>>> options ar... >>>>> 1241.9.7: Monty Taylor 2009-12-14 Fixed setting of C++ standard. >>>>> 1241.9.6: Monty Taylor 2009-12-13 Enhanced our version of >>>>> array_elements. >>>>> 1241.9.5: Monty Taylor 2009-12-13 Fixed the plugin script to not >>>>> bork pl... >>>>> 1241.9.4: Monty Taylor 2009-12-13 Beginnings of what we need to do >>>>> to su... >>>>> 1241.9.3: Monty Taylor 2009-12-13 Fixed the out-of-tree plugin >>>>> file gene... >>>>> 1241.9.2: Monty Taylor 2009-12-13 [merge] Merged meta-info branch. >>>>> 1241.10.4: Monty Taylor 2009-12-12 Actually throw errors on >>>>> failure to... >>>>> 1241.10.3: Monty Taylor 2009-12-12 Throw an error on invalid >>>>> library v... >>>>> 1241.10.2: Monty Taylor 2009-12-11 Added support for embedding >>>>> the dri... >>>>> 1241.10.1: Monty Taylor 2009-12-09 Added ability to specify all >>>>> of the... >>>>> 1241.9.1: Monty Taylor 2009-12-11 Removed global.h. Fixed all the >>>>> headers. >>>>> 1245.1.4: Brian Aker 2009-12-21 [merge] Merge Valgrind. >>>>> 1241.8.1: Monty Taylor 2009-12-21 More valgrind suppressions. >>>>> >>>>> _______________________________________________ >>>>> Mailing list: https://launchpad.net/~drizzle-benchmark >>>>> Post to : [email protected] >>>>> Unsubscribe : https://launchpad.net/~drizzle-benchmark >>>>> More help : https://help.launchpad.net/ListHelp >>>> >>>> _______________________________________________ >>>> Mailing list: https://launchpad.net/~drizzle-benchmark >>>> Post to : [email protected] >>>> Unsubscribe : https://launchpad.net/~drizzle-benchmark >>>> More help : https://help.launchpad.net/ListHelp >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~drizzle-benchmark >>> Post to : [email protected] >>> Unsubscribe : https://launchpad.net/~drizzle-benchmark >>> More help : https://help.launchpad.net/ListHelp >>> > > _______________________________________________ Mailing list: https://launchpad.net/~drizzle-benchmark Post to : [email protected] Unsubscribe : https://launchpad.net/~drizzle-benchmark More help : https://help.launchpad.net/ListHelp
