On Wed, 2008-07-23 at 00:10 +0000, Jim Winstead wrote: > Jim Winstead has proposed merging Fix some compile issues for Mac OS X, and > remove glib for now into Drizzle Active Development Branch.
A few comments. (I much prefer individual mails of patches to list.... very tempted to write a bzr plugin that does this. I hate not having patches in mail to respond to when offline). http://bazaar.launchpad.net/~jimw/drizzle/macosx-fixes/revision/186 should only be marked unused for OSX. otherwise, they are used. for only OSX, you can have in the #ifdef section, (void)parameter; and that squishes the warning for OSX only. http://bazaar.launchpad.net/~jimw/drizzle/macosx-fixes/revision/183 not so sure about this one.... bzr clean-tree is fairly useful, and doing --ignored is... err... good too, but you have to be careful if you use quilt or similar with this. so not really a fan of this one. http://bazaar.launchpad.net/~jimw/drizzle/macosx-fixes/revision/184 only mark unused on platforms where it isn't used. am okay with the removal of embedded stuff, think coding style patches sholud be in sep commits, don't see any current reason for removing glib after we just added it. certainly don't want to go back to my_strdup. frankly, OSX can grow up and get readline and we can have it as a build requirement. http://bazaar.launchpad.net/~jimw/drizzle/macosx-fixes/revision/188 am okay with this one. hope this helps, stewart -- Stewart Smith ([EMAIL PROTECTED]) http://www.flamingspork.com/
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Mailing list: https://launchpad.net/~drizzle-discuss Post to : [email protected] Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
