Hi Montu Monty Taylor wrote:
On a tangent... I noticed some code (in hash.c) that returns false on success and true on failure. I think that this should absolutely die.
That has its reasons. If you read the server Coding Style guide you will see that all functions should return 0 for success (or false) and non-zero (thus true) for error. As usually there are not serveral types of success but there could be several types of errors, 0 is ok for success and you can have different errors. Because it works for functions that return int it should for those returning bool or you have to constantly refer to the function declaration to know whether you should expect 0 for success of true for that.
Andrey _______________________________________________ Mailing list: https://launchpad.net/~drizzle-discuss Post to : [email protected] Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
