Stewart Smith wrote: > On Tue, 2008-07-29 at 17:13 -0400, Jay Pipes wrote: >> Just like we cleaned up the Field_* classes, I would like to begin >> cleaning up the Item_* classes. Currently, like was the case with the >> field stuff, a myriad Item_* classes are housed in a few files in the >> drizzled/ directory: >> >> item.cc >> item_buff.cc >> item_cmpfunc. cc >> item_func.cc >> item_create.cc >> item_row.cc >> item_strfunc.cc >> item_subselect.cc >> item_sum.cc >> item_timefunc.cc >> >> As Brian has stated in the codestyle guidelines, we prefer to have a >> header and codefile per class to aid in maintenance and readability -- >> anyone *really* enjoy dealing with .cc files that are 6549 lines long? >> >> So, I would like to lead off the task of dividing and conquering the >> Item classes. I propose we place all Item classes in their own >> codefiles under an item/ directory within drizzled/. This would make >> the file organization something like this: > > I'm currently working on turning all functions into plugins, redoing the > UDF interface and a few related things...
Hmm, OK then. > is it possible to hold off doing too much there until I finish this > patch (hoping this week... but I said that last week too... mmm... > moving house and hacking go together well). Yes, will do. I have enough to do with cleanup of mysql_priv.h and the include spiderweb. Cheers, Jay _______________________________________________ Mailing list: https://launchpad.net/~drizzle-discuss Post to : [email protected] Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
