Hi!

We should creata accessors to the table object in the handler (and move the current ones from drizzles/ into it as well.

Sent from my iPhone

On Aug 23, 2008, at 2:05 PM, Grant Limberg <[EMAIL PROTECTED]> wrote:

On Aug 23, 2008, at 4:26 AM, Kristian Nielsen wrote:

Grant Limberg <[EMAIL PROTECTED]> writes:

So I'm having a little trouble with the change from 'struct st_table' in drizzled/table.h to 'class Table'. I've removed 'typedef struct st_table TABLE' from storage/innobase/include/row0types.h and replaced all instances of
TABLE* with Table*.

storage/innobase/include/row0merge.h depended on that typedef for
row_merge_build_indexes().  I've tried including either <drizzled/
common_includes.h> or <drizzled/table.h> with joy but pages of error messages.

Here's the current error messages I'm getting:

gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../.. -I../.. -I../.. -I../../ storage/ innobase/include -W -Wall -Wextra -pedantic -Wundef -Wstrict- prototypes
-Wmissing-prototypes -Wmissing-declarations -Wredundant-decls
-Wno-strict-aliasing -DDRIZZLE_DYNAMIC_PLUGIN -ggdb3 -g -O2 -MT
ha_innodb_la-dict0dict.lo -MD -MP -MF .deps/ha_innodb_la- dict0dict.Tpo -c dict/
dict0dict.c  -fno-common -DPIC -o .libs/ha_innodb_la-dict0dict.o
In file included from dict/dict0dict.c:29:
../../storage/innobase/include/row0merge.h:171: error: syntax error before
'Table'
../../storage/innobase/include/row0merge.h:171: warning: function declaration
isn't a prototype
make: *** [ha_innodb_la-dict0dict.lo] Error 1

I'm probably overlooking something small. Anyone have any hints to point me in
the right direction here?

Sorry if I am pointing out the obvious here, but there is the problem that dict0dict.c (like all/most of InnoDB) is C, while class Table is obviously
C++.

If the InnoDB C code uses Table only as an opaque type, you ought to be able to fix it with an appropriate typedef (typedef struct Table *Table). Otherwise
it would seem that some kind of C wrapper is needed for InnoDB?

- Kristian.

That did the trick! I knew it was going to be something obvious like that!

Grant Limberg
[EMAIL PROTECTED]
LinkedIn: http://www.linkedin.com/in/grantlimberg
http://www.glsoftware.net


_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help   : https://help.launchpad.net/ListHelp

_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help   : https://help.launchpad.net/ListHelp

Reply via email to