On Oct 2, 2008, at 3:04 PM, Jay Pipes wrote:

Paul McCullagh wrote:
It's probably useful to go through each of the patches there and re-do some of the work. A bunch of the compiler warnings I solved in rather silly ways. e.g. unused parameters, i just did (void)foo; instead of the
better solution of removing the parameter.

I'm OK with this solution for the moment. Some of these cannot be
changed because they involve callbacks which sometimes/may use the
parameters.

-1  Please let's use __attribute__((unused)) as it is clearer and
indicates to the caller that the argument is not currently used...the
(void)foo; approach doesn't make it clear in the function declaration
that the parameter isn't used.

OK, will change ... phew ... :)


--
Paul McCullagh
PrimeBase Technologies
www.primebase.org
www.blobstreaming.org
pbxt.blogspot.com




_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help   : https://help.launchpad.net/ListHelp

Reply via email to