Eric Day wrote: > On Fri, Nov 07, 2008 at 10:59:35AM +1000, Stewart Smith wrote: >> I think we should checksum individual bits of data, not giant chunks. >> For each batch of rows sent back, checksum that. Not for the entire >> result set. >> >> Remember that for the checksum to be useful we have to be able to know >> it's bad *before* processing any of the data. > > Good point. We currently have the checksum after all chunks for a > packet are sent, and this may be any number of rows in a result set, > depending on how the server chunks this up. It may make sense to > insert a checksum after each chunk, rather than a single computed > from all chunks in a packet. Right now the maximum chunk size is 64k > (2 byte length), so you won't need to waste reading more than that > before you realize a chunk is bad.
I second checksumming each chunk. >> Considering that the code to compute small checksums is tiny, why not >> just have it always on? > > I can still go either way on this. I'm more for making it on by > default, but allow for it to be disabled. But yeah, maybe saving a > few bytes and clock cycles is pointless. :) Please make it default. Most people will just use the default, and then when things go foul, they will start cursing the creators (of the software). If there are some people who are concerned about performance on this level, they can easily turn it off (hopefully well aware of all the consequences). Just my few cents, Mats Kindahl > > -Eric > > _______________________________________________ > Mailing list: https://launchpad.net/~drizzle-discuss > Post to : [email protected] > Unsubscribe : https://launchpad.net/~drizzle-discuss > More help : https://help.launchpad.net/ListHelp -- Mats Kindahl Lead Software Developer Replication Team MySQL AB, www.mysql.com
begin:vcard fn:Mats Kindahl n:Kindahl;Mats org:Sun Microsystems adr;quoted-printable:;;Tegv=C3=A4gen 3;Storvreta;SE;74334;Sweden email;internet:[EMAIL PROTECTED] title:Lead Replication Software Developer x-mozilla-html:FALSE version:2.1 end:vcard
_______________________________________________ Mailing list: https://launchpad.net/~drizzle-discuss Post to : [email protected] Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
