Jim Starkey wrote: > Barry Leslie wrote: >> Hi, >> >> Is there a reason why mysql_rm_db() only calls ha_drop_database() after >> mysql_remove_known_files() returns with out an error? >> >> I would think it would make more sense to call ha_drop_database() >> first to >> allow the handlers a chance to cleanup before >> mysql_remove_known_files() is >> called. >> >> The way it is currently being done makes it complicated for handlers that >> create sub folders in the database to remove them properly before the >> database is dropped. >> >> > I think it would be appropriate if the drizzle server got out of the > business of dropping files on behalf of storage engines. It's > dangerous, saves a trivial amount of code, and violates the layering of > server on storage engine. The whole idea that a) users can control > database file names and b) the server stupidly deletes files by > extension wasn't a really clever idea on day one and hasn't got a whole > lot smarter since. > > If the philosophy is to defer to storage engines, then defer to storage > engines and stop trying to do them favors. > > [And this strong opinion is not strictly from theory.] >
++ _______________________________________________ Mailing list: https://launchpad.net/~drizzle-discuss Post to : [email protected] Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
