Hey guys,

I just tested by-email merge proposal review. Love it.

https://help.launchpad.net/Code/Review

Has the whole skinny. But here's the quick gist.

You put commands on a line by themselves, and the line has to start with
a space.
You have to GPG sign your email, and you have to associated that public
GPG key with your launchpad account.

Commands are:

      review approve - approve the change (alias: +1)
      review disapprove - disapprove of the change (alias: -1)
      review abstain - abstain from deciding (alias: -0 and +0)
      review resubmit - tell the developer to rework the change
      review needs_fixing - tell the developer that a few things need
 improvement (alias: needsfixing and needs-fixing)
      status approve - approve of the merge proposal (alias: approved)
      status reject - reject the merge proposal (alias: rejected)

Review commands are for voting on the proprosal. Status is a final
approval or rejection. You can combine. For instance, on the latest
merge proposal to come in, padraig and I chatted a bit on IRC, so I put:

 review resubmit
 status reject

In the response.

I also put in the notes from our chat, without leading spaces, which get
added to the thread on the merge proposal.

I gotta say - easy as pie.

Monty

_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help   : https://help.launchpad.net/ListHelp

Reply via email to