Hi, Tonight, I spent some time working on replacing the instance of DYNAMIC_ARRAY in the drizzled/show.cc file with STL standards. I've replaced it with std::vector as I think that is the best fit in this scenario. I also use std::sort for sorting the vector and I created a function object to be used as the comparison operator in the std::sort function. I also removed the shrink_var_array() method and use std::remove_if() instead.
I pushed a branch I created with the re-factored code to lp:~posulliv/drizzle/replace-dynamic-array I think that there is still some more re-factoring that can be performed in this case so I havn't proposed a merge yet. Also, I'd like to get the opinion of some people on what I've done to make sure I'm going about this in the right way. So if anyone has any time to have a look at my patch, I'd appreciate any feedback. If you think its worthwhile, I can then look into replacing instances of DYNAMIC_ARRAY in drizzled/set_var.cc and drizzled/sql_plugin.cc after I get this instance I'm working on now replaced. -Padraig _______________________________________________ Mailing list: https://launchpad.net/~drizzle-discuss Post to : [email protected] Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
