Hi Kay!
Feel free to patch in lp:~jaypipes/drizzle/refactor-lex
The commits are small, and mostly just do removal of obselete/dead LEX
members, breakout of header files, and documentation of existing LEX
members...
Cheers,
Jay
Kay Röpke wrote:
Hi!
I'm poking around in the LEX class right now while trying to get rid of
as many parser/Lex_input_stream interactions as possible.
A nasty one is already gone (setting the next lexer state explicitly
when parsing a literal NULL - that was simply a nop) but there are 5
remaining occurences of Lex_input_stream:
1) my_parse_error() - probably harmless, i.e. i'll solve that
differently, with adding an explicit token stream
2+3) remember_name/remember_end - can also solved by having a token stream
4+5) LOAD DATA: it apparently needs to rewrite some of the query for
replication in MySQL. drizzled removed the client code for this code in
the parser (members fname_start/fname_end in LEX)
I suppose these two members should also just go (they are indeed not
referenced anywhere else anymore).
Opinions? Outcries?
If there are none, I'll just zap them.
cheers,
-k
_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to : [email protected]
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help : https://help.launchpad.net/ListHelp
