On Thu, Jul 02, 2009 at 04:19:20PM -0700, Monty Taylor wrote:
> http://drizzle.org/wiki/Refactor_system_variables
s/Refactor/Unfuck/
If I had a dollar for every bug I've fixed there this year... well.. I'd
probably have a (now empty) *really* nice bottle of scotch.
In the first example,
GlobalCounter<uint32_t> gearman_bytes_transferred("bytes_transferred",
0);
SessionCounter<uint32_t>
gearman_session_bytes_transferred(gearman_bytes_transferred);
This means that you can look at session local bytes transfered and at
session end it gets added to GlobalCounter, right?
Should we have:
GlobalCounter<uint32_t> gbt("bytes_transferred")
OR
GlobalCounter<uint32_t> gbt("gearman_bytes_transferred")
?
As in enforce prefix or leave it to plugins?
Some plugins will have existing status vars that they themselves
maintain. How will exporting them work? e.g. something like the
gearmand you're currently connected to. This could change in the gearman
client and the user generally doesn't care... except when they want to
query it. This conflicts with SystemVariable owning the value (as plugin
may not know when set() should be called, as it occus in ext lib)
(and yes, a getValue(std::string *str) will be needed for SHOW)
but does look pretty reasonable.
of course, --help needs to continue to work.
--
Stewart Smith
_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to : [email protected]
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help : https://help.launchpad.net/ListHelp
