Padraig O'Sullivan wrote:
On Wed, Jul 8, 2009 at 3:57 PM, Jay Pipes<[email protected]> wrote:
Some excellent articles here that anyone doing or receiving code reviews
should read.
Thanks for the pointer to those articles Jay; they are quite useful.
One interesting point raised in the articles that I've been wondering
about with regards to Drizzle is who are the reviewers?
Is everyone in the community encouraged to perform code reviews? It
seems to me like this is how it is with Drizzle although I've never
seen it mentioned anywhere. I try to perform code reviews when I feel
I can but sometimes when a feature is being removed or re-factored I
find it difficult as I might not be very familiar with the feature.
Anyone in the Drizzle community is welcome to participate in reviewing
merge proposals and code. Like the first article stresses, both the
reviewer and the submitter learn in the review process.
Cheers!
Jay
-Padraig
Cheers!
Jay
-------- Original Message --------
Subject: Two good articles about doing code reviews
Date: Mon, 06 Jul 2009 19:12:44 +0200
From: Lenz Grimmer <[email protected]>
To: [email protected]
Hi there,
if you are involved in reviewing other developers' code, make sure to take a
look at these two articles:
Your Code Sucks and I Hate You: The Social Dynamics of Code Reviews
http://mumak.net/stuff/your-code-sucks.html
Effective Code Reviews Without the Pain
http://www.developer.com/java/other/article.php/3579756
I've added these links to http://forge.mysql.com/wiki/Code_Review_Process as
well.
Bye,
LenZ
--
Lenz Grimmer - MySQL Community Relations Manager - http://de.sun.com/
Sun Microsystems GmbH, Sonnenallee 1, 85551 Kirchheim-Heimstetten, DE
Geschaeftsfuehrer: Thomas Schroeder, Wolfang Engels, Wolf Frenkel
Vorsitz d. Aufsichtsrates: Martin Haering AG Muenchen: HRB161028
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org
iD8DBQFKUjCSSVDhKrJykfIRAktkAJ9VhuaroUaMA1L5vPAPn2o/vg2njQCffmK+
iBRX/bMhzWqAfXvw/EV2IVk=
=rk1Y
-----END PGP SIGNATURE-----
_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to : [email protected]
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help : https://help.launchpad.net/ListHelp
_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to : [email protected]
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help : https://help.launchpad.net/ListHelp
_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to : [email protected]
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help : https://help.launchpad.net/ListHelp
