Hi,

In libdrizzle/column.c:355 we have:

void drizzle_column_free(drizzle_column_st *column)
{
  if (column->result->column_list == column)
    column->result->column_list= column->next;
  if (column->prev)
    column->prev->next= column->next;
  if (column->next)
    column->next->prev= column->prev;

  if (column->options & DRIZZLE_COLUMN_ALLOCATED)
    free(column);
}

why can't is just be

  if (column->options & DRIZZLE_COLUMN_ALLOCATED)
    free(column);

?

Thanks

   -Diego

P.S. oh, why do I ask, there are times when
column->result->column_list  points to an address that cannot be
accessed (like in this bug
https://bugs.launchpad.net/drizzle/+bug/432210 )
I fixed that one bug, but now I see a new one because
column->prev->next is in an address that cannot be accessed :|





-- 
Diego Medina
Web Developer
http://www.fmpwizard.com

_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help   : https://help.launchpad.net/ListHelp

Reply via email to