You changed the test result. :)

When changing the column type #, you also changed the flags for some
reason. From your patch:

=== modified file 'tests/r/bigint.result'
--- tests/r/bigint.result       2009-04-28 01:03:16 +0000
+++ tests/r/bigint.result       2009-10-03 20:27:53 +0000
@@ -342,22 +342,22 @@
 drop table t1;
 select -9223372036854775808;
 Catalog        Database        Table   Table_alias     Column  Column_alias   
Type     Length  Max length      Is_null Flags   Decimals        Charsetnr
-def                                    -9223372036854775808    5       20     
20       N       32897   0       63
+def                                    -9223372036854775808    4       20     
20       N       129     0       63
 -9223372036854775808
 -9223372036854775808
 select -(9223372036854775808);
 Catalog        Database        Table   Table_alias     Column  Column_alias   
Type     Length  Max length      Is_null Flags   Decimals        Charsetnr
-def                                    -(9223372036854775808)  5       20     
20       N       32897   0       63
+def                                    -(9223372036854775808)  4       20     
20       N       129     0       63
 -(9223372036854775808)
 -9223372036854775808
 select -((9223372036854775808));
 Catalog        Database        Table   Table_alias     Column  Column_alias   
Type     Length  Max length      Is_null Flags   Decimals        Charsetnr
-def                                    -((9223372036854775808))        5      
20       20      N       32897   0       63
+def                                    -((9223372036854775808))        4      
20       20      N       129     0       63
 -((9223372036854775808))
 -9223372036854775808


Just change the flags back to what they were. :)

-Eric

On Fri, Oct 02, 2009 at 05:38:21PM +1000, Stewart Smith wrote:
> On Wed, Sep 30, 2009 at 12:33:06AM -0700, Eric Day wrote:
> > You took a bit too much out, the Drizzle specific types need to match
> > up with the meta types used by both MySQL. The patch should look like:
> 
> applied, and testing... came up with something rather interesting:
> 
> --- tests/r/bigint.reject     2009-10-02 17:20:53.951116956 +1000
> +++ tests/r/bigint.result     2009-10-02 15:51:50.634117377 +1000
> @@ -342,17 +342,17 @@
>  drop table t1;
>  select -9223372036854775808;
>  Catalog      Database        Table   Table_alias     Column  Column_alias    
> Type    Length  Max length      Is_null Flags   Decimals        Charsetnr
> -def                                  -9223372036854775808    4       20      
> 20      N       32897   0       63
> +def                                  -9223372036854775808    4       20      
> 20      N       129     0       63
>  -9223372036854775808
>  -9223372036854775808
>  select -(9223372036854775808);
>  Catalog      Database        Table   Table_alias     Column  Column_alias    
> Type    Length  Max length      Is_null Flags   Decimals        Charsetnr
> -def                                  -(9223372036854775808)  4       20      
> 20      N       32897   0       63
> +def                                  -(9223372036854775808)  4       20      
> 20      N       129     0       63
>  -(9223372036854775808)
>  -9223372036854775808
>  select -((9223372036854775808));
>  Catalog      Database        Table   Table_alias     Column  Column_alias    
> Type    Length  Max length      Is_null Flags   Decimals        Charsetnr
> -def                                  -((9223372036854775808))        4       
> 20      20      N       32897   0       63
> +def                                  -((9223372036854775808))        4       
> 20      20      N       129     0       63
>  -((9223372036854775808))
>  -9223372036854775808
>  select -(-(9223372036854775808));
> 
> 
> Which is the *flags* differing. Rather suspect number too. Any ideas?
> 
> branches are:
> lp:~stewart-flamingspork/drizzle/remove-tinyint
> lp:~stewart-flamingspork/libdrizzle/remove-tinyint
> 
> 
> 
> -- 
> Stewart Smith

_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help   : https://help.launchpad.net/ListHelp

Reply via email to