It should be pointed out that there is currently a noinst lib inside of drizzled right now called libhash which has some of these guys. We do need to continue to have that lib exist. Also, even if the hash impls eventually come from the libhashkit stuff going on in libmemcached, we'll still want the c++ interface inside of drizzle, so the external lib question I think is separate.
The namespace question below is the main question for me. I won't die if we put them in drizzled::algorithm:: ... I'm mainly just offering devil's advocate here. Monty Jay Pipes wrote: > OK, so there are 2 questions, then: > > 1) Should these files (particularly the headers) be moved to a shared, > installable, dependency library project? If so, I would assume it would > be called pandora-something and be shared among libmemcached, gearmand, > drizzled, etc. > > 2) Regardless of whether the files are in a separate library or not, > should hashing functions be included in an xxx::algorithm:: namespace or > should there be a separate namespace just for hashing functions > (xxx::util:: for instance)? > > My personal vote is for: > > A separate library, named libpandora. > > A namespace in said library called pandora::algorithm:: which contains > all algorithms (hashing, sorting, searching, etc). Personally, I feel > hashing functions are in the same category as sort functions and search > functions. > > -jay > > Monty Taylor wrote: >> Ok. That's what Jay is talking about and the reason he advocates >> drizzled::algorithm. >> >> I am saying I don't have a problem with drizzled::algorithm for things >> like sorting and searching, since that's the sort of things you'll find >> in <algorithm> in the STL. But something that just computes a hash >> doesn't belong lumped in with code that searches a container to me. >> >> >> Jay Pipes wrote: >>> Understood, but we are talking about algorithms that are not necessarily >>> restricted to just hashing. For instance, sorting and searching >>> algorithms. We are asking whether drizzled::algorithm:: is an >>> appropriate namespace for this work to go into? Or should it be any of >>> the following? >>> >>> pandora::algorithm:: >>> pandora::util:: >>> drizzled::util:: >>> >>> Something else? >>> >>> -jay >>> >>> Brian Aker wrote: >>>> Hi! >>>> >>>> On Jan 5, 2010, at 11:52 AM, Joe Daly wrote: >>>> >>>>> Currently what resides in this namespace is the crc32 implementation >>>>> used for md5 checksums. >>>> The plan is to copy in libhashkit at some point (or use it if it is >>>> locally installed). We are aways off from this though, but that is the >>>> eventual plan. I want to be able to re-use all of the >>>> hash/distribution work in that library. >>>> >>>> Cheers, >>>> -Brian >>>> _______________________________________________ >>>> Mailing list: https://launchpad.net/~drizzle-discuss >>>> Post to : drizzle-discuss@lists.launchpad.net >>>> Unsubscribe : https://launchpad.net/~drizzle-discuss >>>> More help : https://help.launchpad.net/ListHelp >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~drizzle-discuss >>> Post to : drizzle-discuss@lists.launchpad.net >>> Unsubscribe : https://launchpad.net/~drizzle-discuss >>> More help : https://help.launchpad.net/ListHelp >>> >> > _______________________________________________ Mailing list: https://launchpad.net/~drizzle-discuss Post to : drizzle-discuss@lists.launchpad.net Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
