On Wed, Jan 06, 2010 at 03:47:40AM +0900, Toru Maesaka wrote: > I was looking through index key handling code and discovered the > following enums: > > - HA_KEYTYPE_VARTEXT1 > - HA_KEYTYPE_VARTEXT2
This is mostly just poo. We want to only have VARCHAR being stored with 2 bytes length (and blob in 4). I have a tree for the latter (which somehow causes a failure on some weird platform). > Since MyISAM and HEAP are about the only engines that uses this enum, > would it make sense to consider removing VARTEXT1 and make VARTEXT2, > "the one"?. I understand that this area of the code could be delicate > so I sent this email to see what you all think of this. Yep, that would be ideal. It actually gets a bit tricky to do it fully though... IIRC around (yes you guessed it) internal temporary tables. There's a Field_varstring created with 0 length. Yeah, I'm still going wtf about that too. -- Stewart Smith _______________________________________________ Mailing list: https://launchpad.net/~drizzle-discuss Post to : [email protected] Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
