Hey all, There has been a decent amount of discussion back and forth on Olaf's proposal of adding a common_fwd.h header with forward decls of classes and structs and such.
At first I was pretty lukewarm to this, mainly due to worry about a global header that had to be included before other headers and the nonsense that took us forever to unwind from my_global.h from mysql. The more I thought about it and the more I talked with Olaf though, I am now in favor of the idea... especially since I think it's a great step one in getting us further along towards untangled headers. Consider this process: Make a common_fwd.h header which literally has forward decls for everything Make a branch which removes ALL includes from ALL files and replaces them with common_fwd.h... then, as obviously nothing will compile at that point, anything that's undefined at that point would be something that actually needed a header. Once that got fixed (which would be probably a two-week task) from that point on, as long as common_fwd.h got included, it would mean that including unnecessary headers would be less likely, due to less compiler complaints. I will say though that if common_fwd isn't a first step towards a cleanup of our interwoven headers, then it's not useful. But if it is a first bit of a process, I'm all for it. Monty _______________________________________________ Mailing list: https://launchpad.net/~drizzle-discuss Post to : [email protected] Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
