Oh, and here's the patch by the way:
=== modified file 'config/pandora-plugin'
--- config/pandora-plugin 2011-02-28 18:00:50 +0000
+++ config/pandora-plugin 2011-04-01 04:49:03 +0000
@@ -20,10 +20,19 @@
# Find plugins in the tree and add them to the build system
-import ConfigParser, os, sys
+import os, sys
import datetime, time
import subprocess
+# This assures compatibility between Python 2.x and 3.x
+try: # Python 2.x
+ import ConfigParser
+ os_path_walk = os.path.walk
+except ImportError: # Python 3.x
+ import configparser
+ ConfigParser = configparser
+ os_path_walk = os.walk
+
plugin_am_file=None
plugin_ac_file=None
plugin_doc_index=None
@@ -54,7 +63,7 @@
new_content = self.new_file.read()
self.new_file.close()
try:
- old_file = file(self.real_fname, 'r')
+ old_file = open(self.real_fname, 'r')
old_content = old_file.read()
old_file.close()
except IOError:
@@ -182,7 +191,7 @@
if plugin['writing_status'] == 'done':
return
else:
- print "Dependency loop detected with %s" % plugin['name']
+ sys.stdout.write("Dependency loop detected with %s" % plugin['name'])
exit(1)
plugin['writing_status'] = 'dependencies'
@@ -196,7 +205,7 @@
write_plugin(find_plugin, plugin_ini_list)
break
if found is False:
- print "Could not find dependency %s: %s" % (plugin['name'],
dependency)
+ sys.stdout.write("Could not find dependency %s: %s" %
(plugin['name'], dependency))
exit(1)
write_plugin_ac(plugin, plugin_ac_file)
@@ -341,7 +350,7 @@
def expand_plugin_ini(plugin):
if plugin['name'] == "**OUT-OF-TREE**":
- print "Out of tree plugins require the name field to be specified in
plugin.ini"
+ sys.stdout.write("Out of tree plugins require the name field to be
specified in plugin.ini")
sys.exit(1)
if plugin['plugin_dir'] == ".":
@@ -440,11 +449,11 @@
plugin['plugin_dir'] = plugin_dir
if plugin_dir == '.':
if not plugin.has_key('url'):
- print "External Plugins are required to specifiy a url"
+ sys.stdout.write("External Plugins are required to specifiy a url")
plugin['url']= 'http://launchpad.net/%(name)s' % plugin
sys.exit(1)
if plugin_dir == '.' and not plugin.has_key('version'):
- print "External Plugins are required to specifiy a version"
+ sys.stdout.write("External Plugins are required to specifiy a
version")
sys.exit(1)
if not plugin.has_key('version'):
plugin['version'] = config['default_plugin_version']
@@ -652,7 +661,7 @@
if config['plugin_ini_fname'] in fnames:
arg.append(dirname)
-os.path.walk(os.path.join(config['top_srcdir'],
+os_path_walk(os.path.join(config['top_srcdir'],
config['root_plugin_dir']),
accumulate_plugins,
plugin_list)
@@ -738,7 +747,7 @@
plugin_name_list = [plugin['libname'] for plugin in plugin_ini_list]
for plugin in plugin_ini_list:
if plugin_name_list.count(plugin['libname']) != 1:
- print "Duplicate module name %s" % plugin['libname']
+ sys.stdout.write("Duplicate module name %s" % plugin['libname'])
exit(1)
for plugin in plugin_ini_list:
On Thu, Mar 31, 2011 at 11:28 PM, Juan Antonio Osorio
<[email protected]>wrote:
> Well, I did a patch for the pandora-plugin compatibility issue, and and had
> no problems
> when I ran the autorun.sh script, but when using the makefile I get the
> following error:
>
> drizzled/module/loader.cc:63:30: error: expected unqualified-id before
> ‘__null’
> drizzled/module/loader.cc:64:30: error: expected unqualified-id before
> ‘__null’
> make[2]: *** [drizzled/module/loader.o] Error 1
> make[2]: Leaving directory `/home/ozz/drizzle/trunk'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/home/ozz/drizzle/trunk'
>
> which points to this:
>
> extern drizzled_builtin_list PANDORA_BUILTIN_SYMBOLS_LIST;
> extern drizzled_builtin_list PANDORA_BUILTIN_LOAD_SYMBOLS_LIST;
>
> What could be the problem?
>
>
>
> On Thu, Mar 31, 2011 at 11:15 AM, Juan Antonio Osorio <[email protected]
> > wrote:
>
>> thanks, also, from what I'm seeing, the ones in mysql_protocol are in
>> python 3 synthax O_o.
>>
>>
>>
>> On Thu, Mar 31, 2011 at 11:04 AM, Monty Taylor <[email protected]>wrote:
>>
>>> No, there is also config/pandora-plugin. That is the one I would work on
>>> first, since it is the one which will prevent you from building drizzle
>>> at all if it doesn't work. The others are just related to testing.
>>>
>>> On 03/31/2011 12:50 PM, Juan Antonio Osorio wrote:
>>> > Well, I could give it a try, are these the only python files in the
>>> > source code?
>>> >
>>> > ./plugin/mysql_protocol/prototest/prototest/mysql/command.py
>>> > ./plugin/mysql_protocol/prototest/prototest/mysql/result.py
>>> > ./plugin/mysql_protocol/prototest/prototest/mysql/bitfield.py
>>> > ./plugin/mysql_protocol/prototest/prototest/mysql/handshake.py
>>> > ./plugin/mysql_protocol/prototest/prototest/mysql/__init__.py
>>> > ./plugin/mysql_protocol/prototest/prototest/mysql/column.py
>>> > ./plugin/mysql_protocol/prototest/prototest/mysql/packet.py
>>> > ./plugin/mysql_protocol/prototest/prototest/__init__.py
>>> > ./tests/lib/test_run_options.py
>>> > ./tests/lib/test_mgmt/test_execution.py
>>> > ./tests/lib/test_mgmt/test_management.py
>>> > ./tests/lib/test_mgmt/__init__.py
>>> > ./tests/lib/test_mgmt/execution_management.py
>>> > ./tests/lib/__init__.py
>>> > ./tests/lib/uuid.py
>>> > ./tests/lib/sys_mgmt/logging_management.py
>>> > ./tests/lib/sys_mgmt/port_management.py
>>> > ./tests/lib/sys_mgmt/__init__.py
>>> > ./tests/lib/sys_mgmt/time_management.py
>>> > ./tests/lib/sys_mgmt/codeTree.py
>>> > ./tests/lib/sys_mgmt/system_management.py
>>> > ./tests/lib/test_mode.py
>>> > ./tests/lib/drizzle_test_run/dtr_test_execution.py
>>> > ./tests/lib/drizzle_test_run/dtr_test_management.py
>>> > ./tests/lib/drizzle_test_run/__init__.py
>>> > ./tests/lib/server_mgmt/server.py
>>> > ./tests/lib/server_mgmt/__init__.py
>>> > ./tests/lib/server_mgmt/drizzled.py
>>> > ./tests/lib/server_mgmt/server_management.py
>>> > ./tests/lib/randgen/randgen_test_execution.py
>>> > ./tests/lib/randgen/__init__.py
>>> > ./tests/lib/randgen/randgen_test_management.py
>>> > ./tests/dbqp.py
>>> > ./docs/conf.py
>>> > ./docs/pyext/dbtable.py
>>> > ./docs/pyext/confval.py
>>> > ./docs/pyext/__init__.py
>>> > ./docs/pyext/options.py
>>> >
>>> >
>>> > On Thu, Mar 31, 2011 at 2:35 AM, Monty Taylor <[email protected]
>>> > <mailto:[email protected]>> wrote:
>>> >
>>> > On 03/31/2011 02:20 AM, Andrew Hutchings wrote:
>>> > > Hi Juan,
>>> > >
>>> > > On 31/03/11 02:22, Juan Antonio Osorio wrote:
>>> > >> My name is Juan Antonio and I'm interested in applying to work
>>> in the
>>> > >> project in summer
>>> > >> through the GSoC, but when I tried to compile the source code I
>>> > got this:
>>> > >>
>>> > >> I'm guessing that plugin depends on python2.7 and I'm using
>>> > python3.2.
>>> > >> Does the code depend
>>> > >> on a lot of python code? maybe I could port it or try to make it
>>> > syntax
>>> > >> independent.
>>> > >
>>> > > That is the Pandora build system, and yes it depends upon Python
>>> > 2.x. I
>>> > > think the only other two things we use python for is docs (using
>>> > > python-sphinx) and testing (tests/dbqp).
>>> > >
>>> > > As for porting Pandora I would recommend talking to Monty Taylor
>>> > > (mtaylor on IRC) since he heads that project.
>>> >
>>> > I would totally accept patches to allow pandora-build to run in
>>> python3,
>>> > as long as they will also work with python2 (since most of the
>>> distros
>>> > have not moved yet)
>>> >
>>> > Monty
>>> >
>>> > _______________________________________________
>>> > Mailing list: https://launchpad.net/~drizzle-discuss
>>> > <https://launchpad.net/%7Edrizzle-discuss>
>>> > Post to : [email protected]
>>> > <mailto:[email protected]>
>>> > Unsubscribe : https://launchpad.net/~drizzle-discuss
>>> > <https://launchpad.net/%7Edrizzle-discuss>
>>> > More help : https://help.launchpad.net/ListHelp
>>> >
>>> >
>>> >
>>> >
>>> > --
>>> > Juan Antonio Osorio R.
>>> > e-mail: [email protected] <mailto:[email protected]>
>>> >
>>> > "All truly great thoughts are conceived by walking."
>>> > - F.N.
>>> >
>>> >
>>>
>>>
>>
>>
>> --
>> Juan Antonio Osorio R.
>> e-mail: [email protected]
>>
>> "All truly great thoughts are conceived by walking."
>> - F.N.
>>
>>
>>
>
>
> --
> Juan Antonio Osorio R.
> e-mail: [email protected]
>
> "All truly great thoughts are conceived by walking."
> - F.N.
>
>
>
--
Juan Antonio Osorio R.
e-mail: [email protected]
"All truly great thoughts are conceived by walking."
- F.N.
_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to : [email protected]
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help : https://help.launchpad.net/ListHelp
