On Sun, Apr 10, 2011 at 03:33, Muhammad Umair <[email protected]> wrote: > Hi, > > Thanks for the guidance. I executed 'make test' and all the tests went > successful. The following is the output: > > ====================================== > Stopping All Servers > All 564 tests were successful. > The servers were restarted 55 times > Spent 415.009 of 724 seconds executing testcases > > make[3]: Leaving directory > `/mnt/d/drizzle/repos/drizzle/drizzle-fix-bug621859' > make[2]: Leaving directory > `/mnt/d/drizzle/repos/drizzle/drizzle-fix-bug621859' > Making check in po > make[2]: Entering directory > `/mnt/d/drizzle/repos/drizzle/drizzle-fix-bug621859/po' > INTLTOOL_EXTRACT=/usr/bin/intltool-extract XGETTEXT=/usr/bin/xgettext > srcdir=. /usr/bin/intltool-update --gettext-package drizzle7 --pot > rm -f missing notexist > srcdir=. /usr/bin/intltool-update -m > mismatched quotes at line 644 in > ../plugin/innobase/xtrabackup/xtrabackup.cc > if [ -r missing -o -r notexist -a "xyes" = "xyes" ]; then \ > exit 1; \ > fi > make[2]: Leaving directory > `/mnt/d/drizzle/repos/drizzle/drizzle-fix-bug621859/po' > make[1]: Leaving directory > `/mnt/d/drizzle/repos/drizzle/drizzle-fix-bug621859' > > ====================================== > > So does it mean that I am ready to push my changes to launchpad?. I also > attached the scripts that I executed for removing the stale header > statements from the drizzle code base. >
Yeah you can do so now and notify a merge captain about that. Then he would review your code and maybe test it on Jenkins build slaves. And if all goes well, your code will be approved :) > Thanks for the help. > > Umair Muhammad > Electrical Engineering Master Student, > Specialization in Wireless Systems, > School of Electrical Engineering, > Royal Institute of Technology (KTH), > SE 100-44 Stockholm, SWEDEN. > Email: [email protected] > Cell: +46 764 097 574 > > > ________________________________________ > From: Abhishek Singh [[email protected]] > Sent: Saturday, April 09, 2011 3:32 PM > To: Muhammad Umair > Cc: [email protected]; [email protected] > Subject: Re: [Drizzle-discuss] Bug#621859 error > > On Sat, Apr 9, 2011 at 16:35, Muhammad Umair <[email protected]<mailto: > [email protected]>> wrote: > > Dear Andrew, > > I ran the attached script for removing the stale headers from the drizzle > code base. The script were executed in the following order: > > ./script.sh > ./script_1.sh > ./script_2.sh > egrep -ire "#include <drizzled/>" * | cut -f1 -d':' |xargs sed -i > 's/#include\ <drizzled\/>//g' > > After that, I executed the following command: > > ./config/autoconfig.sh <<<< Successful > ./configure <<<< Successful > make <<<< Successful > Are you sure that there weren't any error messages in this case. Please > check that again. In my case I always keep log of compile process of any bug > branch by redirecting output of terminal to a file. > make install <<< This command returned the following error. > I think you don't need to run make install in this case. Just run "make > test", it will test your drizzle-bug-621859 branch against all the 564 test > cases. If that goes well then push your code to launchpad and notify a Merge > Captain of your code pushes. > > umair@umair-laptop:~/Desktop/d/drizzle/repos/drizzle/drizzle-fix-bug621859$ > sudo make install > [sudo] password for umair: > cd . && python config/pandora-plugin write > make install-recursive > make[1]: Entering directory > `/mnt/d/drizzle/repos/drizzle/drizzle-fix-bug621859' > cd . && python config/pandora-plugin write > Making install in . > make[2]: Entering directory > `/mnt/d/drizzle/repos/drizzle/drizzle-fix-bug621859' > cd . && python config/pandora-plugin write > rm -f -f tests/test-run > ln -s test-run.pl<http://test-run.pl> tests/test-run > make[3]: Entering directory > `/mnt/d/drizzle/repos/drizzle/drizzle-fix-bug621859' > cd . && python config/pandora-plugin write > test -z "/usr/local/lib" || /bin/mkdir -p "/usr/local/lib" > /bin/bash ./libtool --mode=install /usr/bin/install -c > drizzled/message/libdrizzledmessage.la<http://libdrizzledmessage.la> > libdrizzle-2.0/libdrizzle/libdrizzle.la<http://libdrizzle.la> > '/usr/local/lib' > libtool: install: /usr/bin/install -c > drizzled/message/.libs/libdrizzledmessage.so.0.0.0 > /usr/local/lib/libdrizzledmessage.so.0.0.0 > libtool: install: (cd /usr/local/lib && { ln -s -f > libdrizzledmessage.so.0.0.0 libdrizzledmessage.so.0 || { rm -f > libdrizzledmessage.so.0 && ln -s libdrizzledmessage.so.0.0.0 > libdrizzledmessage.so.0; }; }) > libtool: install: (cd /usr/local/lib && { ln -s -f > libdrizzledmessage.so.0.0.0 libdrizzledmessage.so || { rm -f > libdrizzledmessage.so && ln -s libdrizzledmessage.so.0.0.0 > libdrizzledmessage.so; }; }) > libtool: install: /usr/bin/install -c > drizzled/message/.libs/libdrizzledmessage.lai /usr/local/lib/ > libdrizzledmessage.la<http://libdrizzledmessage.la> > libtool: install: /usr/bin/install -c > libdrizzle-2.0/libdrizzle/.libs/libdrizzle.so.3.0.0 > /usr/local/lib/libdrizzle.so.3.0.0 > libtool: install: (cd /usr/local/lib && { ln -s -f libdrizzle.so.3.0.0 > libdrizzle.so.3 || { rm -f libdrizzle.so.3 && ln -s libdrizzle.so.3.0.0 > libdrizzle.so.3; }; }) > libtool: install: (cd /usr/local/lib && { ln -s -f libdrizzle.so.3.0.0 > libdrizzle.so || { rm -f libdrizzle.so && ln -s libdrizzle.so.3.0.0 > libdrizzle.so; }; }) > libtool: install: /usr/bin/install -c > libdrizzle-2.0/libdrizzle/.libs/libdrizzle.lai /usr/local/lib/ > libdrizzle.la<http://libdrizzle.la> > libtool: finish: > PATH="/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/X11R6/bin:/sbin" > ldconfig -n /usr/local/lib > ---------------------------------------------------------------------- > > Libraries have been installed in: > /usr/local/lib > > If you ever happen to want to link against installed libraries > in a given directory, LIBDIR, you must either use libtool, and > specify the full pathname of the library, or use the `-LLIBDIR' > flag during linking and do at least one of the following: > - add LIBDIR to the `LD_LIBRARY_PATH' environment variable > during execution > - add LIBDIR to the `LD_RUN_PATH' environment variable > during linking > - use the `-Wl,-rpath -Wl,LIBDIR' linker flag > - have your system administrator add LIBDIR to `/etc/ld.so.conf' > > See any operating system documentation about shared libraries for > more information, such as the ld(1) and ld.so(8) manual pages. > ---------------------------------------------------------------------- > > test -z "/usr/local/bin" || /bin/mkdir -p "/usr/local/bin" > /bin/bash ./libtool --mode=install /usr/bin/install -c > plugin/innobase/xtrabackup/drizzlebackup.innobase client/drizzle > client/drizzleadmin client/drizzledump client/drizzleimport > client/drizzleslap '/usr/local/bin' > libtool: install: /usr/bin/install -c > plugin/innobase/xtrabackup/drizzlebackup.innobase > /usr/local/bin/drizzlebackup.innobase > libtool: install: /usr/bin/install -c client/.libs/drizzle > /usr/local/bin/drizzle > libtool: install: /usr/bin/install -c client/.libs/drizzleadmin > /usr/local/bin/drizzleadmin > libtool: install: /usr/bin/install -c client/.libs/drizzledump > /usr/local/bin/drizzledump > libtool: install: /usr/bin/install -c client/.libs/drizzleimport > /usr/local/bin/drizzleimport > libtool: install: /usr/bin/install -c client/.libs/drizzleslap > /usr/local/bin/drizzleslap > test -z "/usr/local/sbin" || /bin/mkdir -p "/usr/local/sbin" > /bin/bash ./libtool --mode=install /usr/bin/install -c drizzled/drizzled > '/usr/local/sbin' > libtool: install: /usr/bin/install -c drizzled/.libs/drizzled > /usr/local/sbin/drizzled > make install-exec-hook > make[4]: Entering directory > `/mnt/d/drizzle/repos/drizzle/drizzle-fix-bug621859' > cd . && python config/pandora-plugin write > cd /usr/local/sbin && \ > mv -f drizzled drizzled7 && \ > ln -s drizzled7 drizzled > make[4]: Leaving directory > `/mnt/d/drizzle/repos/drizzle/drizzle-fix-bug621859' > test -z "/usr/local/include" || /bin/mkdir -p "/usr/local/include" > test -z "/usr/local/include/libdrizzle-2.0/libdrizzle" || /bin/mkdir -p > "/usr/local/include/libdrizzle-2.0/libdrizzle" > /usr/bin/install -c -m 644 libdrizzle-2.0/libdrizzle/column.h > libdrizzle-2.0/libdrizzle/column_client.h > libdrizzle-2.0/libdrizzle/column_server.h > libdrizzle-2.0/libdrizzle/command_client.h > libdrizzle-2.0/libdrizzle/command_server.h libdrizzle-2.0/libdrizzle/conn.h > libdrizzle-2.0/libdrizzle/conn_client.h > libdrizzle-2.0/libdrizzle/conn_server.h > libdrizzle-2.0/libdrizzle/constants.h libdrizzle-2.0/libdrizzle/drizzle.h > libdrizzle-2.0/libdrizzle/drizzle_client.h > libdrizzle-2.0/libdrizzle/drizzle_server.h > libdrizzle-2.0/libdrizzle/field_client.h > libdrizzle-2.0/libdrizzle/field_server.h > libdrizzle-2.0/libdrizzle/handshake_client.h > libdrizzle-2.0/libdrizzle/handshake_server.h > libdrizzle-2.0/libdrizzle/libdrizzle.h libdrizzle-2.0/libdrizzle/query.h > libdrizzle-2.0/libdrizzle/result.h libdrizzle-2.0/libdrizzle/result_client.h > libdrizzle-2.0/libdrizzle/result_server.h > libdrizzle-2.0/libdrizzle/row_client.h > libdrizzle-2.0/libdrizzle/row_server.h libdrizzle-2.0/libdrizzle/structs.h > libdrizzle-2.0/libdrizzle/visibility.h > '/usr/local/include/libdrizzle-2.0/libdrizzle' > test -z "/usr/local/include/libdrizzle-1.0/libdrizzle" || /bin/mkdir -p > "/usr/local/include/libdrizzle-1.0/libdrizzle" > /usr/bin/install -c -m 644 libdrizzle-1.0/libdrizzle/column.h > libdrizzle-1.0/libdrizzle/column_client.h > libdrizzle-1.0/libdrizzle/column_server.h > libdrizzle-1.0/libdrizzle/command_client.h > libdrizzle-1.0/libdrizzle/command_server.h libdrizzle-1.0/libdrizzle/conn.h > libdrizzle-1.0/libdrizzle/conn_client.h > libdrizzle-1.0/libdrizzle/conn_server.h > libdrizzle-1.0/libdrizzle/constants.h libdrizzle-1.0/libdrizzle/drizzle.h > libdrizzle-1.0/libdrizzle/drizzle_client.h > libdrizzle-1.0/libdrizzle/drizzle_server.h > libdrizzle-1.0/libdrizzle/field_client.h > libdrizzle-1.0/libdrizzle/field_server.h > libdrizzle-1.0/libdrizzle/handshake_client.h > libdrizzle-1.0/libdrizzle/handshake_server.h > libdrizzle-1.0/libdrizzle/libdrizzle.h libdrizzle-1.0/libdrizzle/query.h > libdrizzle-1.0/libdrizzle/result.h libdrizzle-1.0/libdrizzle/result_client.h > libdrizzle-1.0/libdrizzle/result_server.h > libdrizzle-1.0/libdrizzle/row_client.h > libdrizzle-1.0/libdrizzle/row_server.h libdrizzle-1.0/libdrizzle/structs.h > libdrizzle-1.0/libdrizzle/visibility.h > '/usr/local/include/libdrizzle-1.0/libdrizzle' > test -z "/usr/local/include/drizzle7" || /bin/mkdir -p > "/usr/local/include/drizzle7" > test -z "/usr/local/lib" || /bin/mkdir -p "/usr/local/lib" > test -z "/usr/local/lib/pkgconfig" || /bin/mkdir -p > "/usr/local/lib/pkgconfig" > /usr/bin/install -c -m 644 support-files/libdrizzle-2.0.pc > '/usr/local/lib/pkgconfig' > test -z "/usr/local/share/man/man1" || /bin/mkdir -p > "/usr/local/share/man/man1" > /usr/bin/install -c -m 644 client/drizzle.1 client/drizzleimport.1 > client/drizzleslap.1 '/usr/local/share/man/man1' > test -z "/usr/local/share/man/man8" || /bin/mkdir -p > "/usr/local/share/man/man8" > /usr/bin/install -c -m 644 client/drizzled.8 '/usr/local/share/man/man8' > test -z "/usr/local/include" || /bin/mkdir -p "/usr/local/include" > test -z "/usr/local/include/drizzle7" || /bin/mkdir -p > "/usr/local/include/drizzle7" > /bin/mkdir -p '/usr/local/include/drizzle7/drizzled' > /usr/bin/install -c -m 644 drizzled/abort_exception.h > drizzled/alter_column.h drizzled/alter_info.h drizzled/atomics.h > drizzled/base.h drizzled/cached_directory.h drizzled/cached_item.h > drizzled/calendar.h drizzled/catalog.h drizzled/charset.h ./drizzled/ > drizzled/check_stack_overrun.h drizzled/common.h drizzled/common_fwd.h > drizzled/comp_creator.h drizzled/constrained_value.h drizzled/copy_field.h > drizzled/copy_info.h drizzled/create_field.h drizzled/current_session.h > drizzled/cursor.h drizzled/daemon.h drizzled/data_home.h drizzled/debug.h > drizzled/definitions.h drizzled/diagnostics_area.h > drizzled/discrete_interval.h drizzled/display.h drizzled/drizzled.h > drizzled/dtcollation.h drizzled/dynamic_array.h drizzled/enum.h > drizzled/enum_nested_loop_state.h drizzled/errmsg_print.h drizzled/error.h > drizzled/error_t.h drizzled/execute.h drizzled/field.h > drizzled/field_iterator.h drizzled/file_exchange.h > '/usr/local/include/drizzle7/drizzled' > /usr/bin/install: omitting directory `./drizzled/' > make[3]: *** [install-nobase_dist_pkgincludeHEADERS] Error 1 > make[3]: Leaving directory > `/mnt/d/drizzle/repos/drizzle/drizzle-fix-bug621859' > make[2]: *** [install-am] Error 2 > make[2]: Leaving directory > `/mnt/d/drizzle/repos/drizzle/drizzle-fix-bug621859' > make[1]: *** [install-recursive] Error 1 > make[1]: Leaving directory > `/mnt/d/drizzle/repos/drizzle/drizzle-fix-bug621859' > make: *** [install] Error 2 > > > > Regards > > Umair Muhammad > Electrical Engineering Master Student, > Specialization in Wireless Systems, > School of Electrical Engineering, > Royal Institute of Technology (KTH), > SE 100-44 Stockholm, SWEDEN. > Email: [email protected]<mailto:[email protected]> > Cell: +46 764 097 574 > _______________________________________________ > Mailing list: https://launchpad.net/~drizzle-discuss > Post to : [email protected]<mailto: > [email protected]> > Unsubscribe : https://launchpad.net/~drizzle-discuss > More help : https://help.launchpad.net/ListHelp > > Regards, Abhishek Kumar Singh http://www.mapbender.org/User:Abhishek BE/1349/2007 Information Technology 8th SEMESTER BIT MESRA Skype: singhabhishek.bit Mobile: +91-8002111189 irc-nick: sin8h (irc.freenode.net)
_______________________________________________ Mailing list: https://launchpad.net/~drizzle-discuss Post to : [email protected] Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
